Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dev): handling configuration for websocket enabled by default (WPB-967) #1901

Merged
merged 4 commits into from
Jul 3, 2023
Merged

feat(dev): handling configuration for websocket enabled by default (WPB-967) #1901

merged 4 commits into from
Jul 3, 2023

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Jul 3, 2023 •
edited by github-actions bot
Loading

@yamilmedina yamilmedina self-assigned this Jul 3, 2023
@yamilmedina yamilmedina requested review from a team, gongracr, borichellow, vitorhugods, mchenani, Garzas, MohamadJaara and trOnk12 and removed request for a team July 3, 2023 14:06
@AndroidBob
Copy link
Collaborator

Build 168 failed.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023 •
edited
Loading

Unit Test Results

  70 files  ±0    70 suites  ±0   43s ⏱️ -4s
442 tests ±0  441 ✔️ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit 8d7e801. ± Comparison against base commit 7519d5a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

Build (dev-debug) available here. Scroll down to Artifacts!

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

Build (beta-debug) available here. Scroll down to Artifacts!

@yamilmedina yamilmedina added this pull request to the merge queue Jul 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

Build (dev-debug) available here. Scroll down to Artifacts!

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

Build (beta-debug) available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 174 succeeded.

The build produced the following APK's:

Merged via the queue into develop with commit ec3fc30 Jul 3, 2023
@yamilmedina yamilmedina deleted the feat/websocket-by-default-dev branch July 3, 2023 15:59
@yamilmedina yamilmedina mentioned this pull request Jul 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandreferris alexandreferris alexandreferris approved these changes

@vitorhugods vitorhugods vitorhugods approved these changes

@gongracr gongracr Awaiting requested review from gongracr gongracr was automatically assigned from wireapp/android

@borichellow borichellow Awaiting requested review from borichellow borichellow was automatically assigned from wireapp/android

@mchenani mchenani Awaiting requested review from mchenani mchenani was automatically assigned from wireapp/android

@Garzas Garzas Awaiting requested review from Garzas Garzas was automatically assigned from wireapp/android

@MohamadJaara MohamadJaara Awaiting requested review from MohamadJaara

@trOnk12 trOnk12 Awaiting requested review from trOnk12

Assignees

@yamilmedina yamilmedina

Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yamilmedina @AndroidBob @alexandreferris @vitorhugods