feat(RC): SSO email login #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* redirect to the webpage * redirect to the webpage * cleanup * unit tests * update kalium * update kalium * Update app/src/main/kotlin/com/wire/android/ui/authentication/login/sso/LoginSSOViewModel.kt Co-authored-by: Alexandre Ferris <[email protected]> --------- Co-authored-by: Alexandre Ferris <[email protected]>
|
Build (beta-debug) available here. Scroll down to Artifacts! |
|
Build (dev-debug) available here. Scroll down to Artifacts! |
|
Build 2 succeeded. The build produced the following APK's: |
MohamadJaara
requested review from
a team,
gongracr,
alexandreferris,
borichellow,
ohassine and
saleniuk
and removed request for
a team
alexandreferris
approved these changes
Jul 5, 2023
…_login_RC_UI # Conflicts: # app/src/main/kotlin/com/wire/android/di/CoreLogicModule.kt
vitorhugods
reviewed
Jul 7, 2023
Comment on lines
+136
to
+137
| @VisibleForTesting | ||
| fun domainLookupFlow() { |
There was a problem hiding this comment.
@VisibleForTesting
but it's public anyway
vitorhugods
approved these changes
Jul 7, 2023
|
Build (beta-debug) available here. Scroll down to Artifacts! |
|
Build (dev-debug) available here. Scroll down to Artifacts! |
yamilmedina
approved these changes
Jul 7, 2023
|
Build 6 succeeded. The build produced the following APK's: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
domain lookup in the sso login screen and sso login with email
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.