Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly map flowStatus for decryption failures WPB-2428 #1912

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

tmspzz
Copy link
Contributor

@tmspzz tmspzz commented Jul 6, 2023

BugWPB-2428 [Android] Reset Session button not visible anymore after decryption error is received


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Failures to Decrypt are showing as regular messages in the UI with not associated resolution action

Causes (Optional)

flowStatus is missing mappings for decryption failures

Solutions

Add mappings and relative tests for decryption failures

Testing

Test Coverage (Optional)

  • Added assets in appropriate test
  • Added mock DECRYPTION_FAILURE message

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@tmspzz tmspzz requested a review from Garzas July 6, 2023 13:34
@tmspzz tmspzz requested review from a team, typfel, MohamadJaara, vitorhugods and trOnk12 and removed request for a team July 6, 2023 13:34
@tmspzz tmspzz force-pushed the fix/WPB-2428-missing-ui-failure-to-decrypt branch from 556c025 to 2e3ce13 Compare July 6, 2023 13:40
@tmspzz tmspzz force-pushed the fix/WPB-2428-missing-ui-failure-to-decrypt branch from 2e3ce13 to 6a3e3e1 Compare July 6, 2023 13:42
@AndroidBob
Copy link
Collaborator

Build 236 failed.

@tmspzz tmspzz force-pushed the fix/WPB-2428-missing-ui-failure-to-decrypt branch from 6a3e3e1 to 247f9cc Compare July 6, 2023 14:06
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Unit Test Results

  72 files  ±0    72 suites  ±0   28s ⏱️ +7s
451 tests ±0  450 ✔️ ±0  1 💤 ±0  0 ±0 

Results for commit 247f9cc. ± Comparison against base commit be901c6.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Build (beta-debug) available here. Scroll down to Artifacts!

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Build (dev-debug) available here. Scroll down to Artifacts!

Merged via the queue into develop with commit b46964f Jul 6, 2023
@tmspzz tmspzz deleted the fix/WPB-2428-missing-ui-failure-to-decrypt branch July 6, 2023 14:35
@AndroidBob
Copy link
Collaborator

Build 239 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants