Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable standard reactions [APB-826] #1919

Merged
merged 4 commits into from
Jul 18, 2023
Merged

Conversation

vitorhugods
Copy link
Member

And remove hacky code from the UI layer now that Kalium handles it properly


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When we came up with Reactions, some hacky code was added to keep compatibility between clients.
Now that Web and iOS are implementing reactions too, we can remove it.

Solutions

Visual Representation Unicode Symbols Comment
Single symbol: \u2764 Expected by old Android and exchanged between clients during the “Likes” era
❤️ Two symbols: \u2764\uFE0F Default used by Web, iOS and Android during the “Reactions” era

Now in Kalium, all heart reactions are stored as ❤️. So this means we can remove all hacky code used to display the heart reactions.

When sending, we are also sending the ❤️ emoji.

Testing

N/A


PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

And remove hacky code from the UI layer now that Kalium handles it properly
@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2023

Unit Test Results

  72 files    72 suites   24s ⏱️
451 tests 450 ✔️ 1 💤 0

Results for commit e7b1926.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

Build (beta-debug) available here. Scroll down to Artifacts!

@github-actions
Copy link
Contributor

Build (dev-debug) available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 295 succeeded.

The build produced the following APK's:

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #1919 (b7cf6d7) into develop (0c375a7) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #1919      +/-   ##
=============================================
- Coverage      36.56%   36.52%   -0.04%     
  Complexity       847      847              
=============================================
  Files            287      287              
  Lines          11299    11285      -14     
  Branches        1449     1446       -3     
=============================================
- Hits            4131     4122       -9     
+ Misses          6760     6757       -3     
+ Partials         408      406       -2     
Impacted Files Coverage Δ
...in/kotlin/com/wire/android/mapper/MessageMapper.kt 62.62% <100.00%> (-0.21%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43d26d8...b7cf6d7. Read the comment docs.

@github-actions
Copy link
Contributor

Build (beta-debug) available here. Scroll down to Artifacts!

@github-actions
Copy link
Contributor

Build (dev-debug) available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 305 succeeded.

The build produced the following APK's:

@vitorhugods
Copy link
Member Author

Signaling not to merge as merging this will cause weird interactions with the current iOS client.

We can wait a bit until it's closer to next release of the iOS app.

@vitorhugods vitorhugods enabled auto-merge July 18, 2023 13:59
@vitorhugods vitorhugods added this pull request to the merge queue Jul 18, 2023
@github-actions
Copy link
Contributor

Build (beta-debug) available here. Scroll down to Artifacts!

@github-actions
Copy link
Contributor

Build (dev-debug) available here. Scroll down to Artifacts!

@github-actions
Copy link
Contributor

Test Results

463 tests   462 ✔️  21s ⏱️
  72 suites      1 💤
  72 files        0

Results for commit b7cf6d7.

@AndroidBob
Copy link
Collaborator

Build 481 succeeded.

The build produced the following APK's:

Merged via the queue into develop with commit 8906f0c Jul 18, 2023
@vitorhugods vitorhugods deleted the chore/enable_reactions branch July 18, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants