-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enable standard reactions [APB-826] #1919
Conversation
And remove hacky code from the UI layer now that Kalium handles it properly
Build (beta-debug) available here. Scroll down to Artifacts! |
Build (dev-debug) available here. Scroll down to Artifacts! |
Build 295 succeeded. The build produced the following APK's: |
Codecov Report
@@ Coverage Diff @@
## develop #1919 +/- ##
=============================================
- Coverage 36.56% 36.52% -0.04%
Complexity 847 847
=============================================
Files 287 287
Lines 11299 11285 -14
Branches 1449 1446 -3
=============================================
- Hits 4131 4122 -9
+ Misses 6760 6757 -3
+ Partials 408 406 -2
Continue to review full report in Codecov by Sentry.
|
Build (beta-debug) available here. Scroll down to Artifacts! |
Build (dev-debug) available here. Scroll down to Artifacts! |
Build 305 succeeded. The build produced the following APK's: |
Signaling not to merge as merging this will cause weird interactions with the current iOS client. We can wait a bit until it's closer to next release of the iOS app. |
Build (beta-debug) available here. Scroll down to Artifacts! |
Build (dev-debug) available here. Scroll down to Artifacts! |
Build 481 succeeded. The build produced the following APK's: |
And remove hacky code from the UI layer now that Kalium handles it properly
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
When we came up with Reactions, some hacky code was added to keep compatibility between clients.
Now that Web and iOS are implementing reactions too, we can remove it.
Solutions
❤
❤️
Now in Kalium, all heart reactions are stored as
❤️
. So this means we can remove all hacky code used to display the heart reactions.When sending, we are also sending the
❤️
emoji.Testing
N/A
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.