Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add timer to all message types #1920

Merged
merged 10 commits into from
Jul 13, 2023

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

atm message timer is only applicable to Text and Asset Messages.

Solutions

  1. when mapping from proto Text, Asset, Location, Knock and Image message content have a timer. And since the message timer value in the DB is applicable to all message types.
  2. map knock messages from ephemeral content.
  3. remove any type check when queuing ephemeral messages

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2023

Unit Test Results

  3 files    3 suites   0s ⏱️
12 tests 12 ✔️ 0 💤 0

Results for commit 9762047.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 4 failed.

@github-actions
Copy link
Contributor

Build (beta-debug) available here. Scroll down to Artifacts!

@github-actions
Copy link
Contributor

Build (dev-debug) available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 6 succeeded.

The build produced the following APK's:

@MohamadJaara MohamadJaara requested review from a team, yamilmedina, vitorhugods, mchenani, trOnk12 and ohassine and removed request for a team July 11, 2023 08:21
@github-actions
Copy link
Contributor

Build (beta-debug) available here. Scroll down to Artifacts!

@github-actions
Copy link
Contributor

Build (dev-debug) available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 7 succeeded.

The build produced the following APK's:

@MohamadJaara MohamadJaara changed the title fix: feat: add timer to all message types feat: add timer to all message types Jul 12, 2023
@MohamadJaara MohamadJaara enabled auto-merge (squash) July 13, 2023 10:09
@MohamadJaara MohamadJaara disabled auto-merge July 13, 2023 10:10
@MohamadJaara MohamadJaara merged commit 3443c1a into release/candidate Jul 13, 2023
@MohamadJaara MohamadJaara deleted the fix/self_deleting_pings branch July 13, 2023 10:11
@AndroidBob
Copy link
Collaborator

Build 8 failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants