feat: save backup file locally [WPB-1827] [WPB-762] #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build (beta-debug) available here. Scroll down to Artifacts! |
|
Build (dev-debug) available here. Scroll down to Artifacts! |
|
Build 300 succeeded. The build produced the following APK's: |
saleniuk
requested review from
a team,
gongracr,
MohamadJaara,
vitorhugods,
mchenani and
trOnk12
and removed request for
a team and
gongracr
ohassine
reviewed
Jul 11, 2023
app/src/main/kotlin/com/wire/android/util/permission/CreateFileRequestFlow.kt
Show resolved
Hide resolved
alexandreferris
approved these changes
Jul 11, 2023
app/src/main/kotlin/com/wire/android/util/permission/CreateFileRequestFlow.kt
Show resolved
Hide resolved
ohassine
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Until now it’s only possible to share them through a 3rd party application, but it would be nice to have an option to save it on our devices.
Solutions
Add another action after creating a backup file, so that we can either "save backup file" or "share backup file".
Testing
Test Coverage (Optional)
How to Test
Create a backup and save it.
Attachments (Optional)
save_backup_locally.mp4
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.