Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cherry pick from rc to develop #1951

Merged
merged 2 commits into from
Jul 18, 2023
Merged

chore: cherry pick from rc to develop #1951

merged 2 commits into from
Jul 18, 2023

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Jul 17, 2023

Develop PR: #1947

vitorhugods
vitorhugods approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@vitorhugods vitorhugods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this one will trigger itself after merging 😅

@Garzas
Copy link
Contributor Author

Garzas commented Jul 17, 2023

I wonder if this one will trigger itself after merging 😅

No, because it doesn't have branch name containing /rc- 😄

@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2023 •
edited
Loading

Unit Test Results

  71 files    71 suites   51s ⏱️
482 tests 481 ✔️ 1 💤 0 ❌

Results for commit 03af096.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

Build (dev-debug) available here. Scroll down to Artifacts!

@github-actions
Copy link
Contributor

Build (beta-debug) available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1 succeeded.

The build produced the following APK's:

@vitorhugods
Copy link
Member

vitorhugods commented Jul 17, 2023 •
edited
Loading

I wonder if this one will trigger itself after merging 😅

No, because it doesn't have branch name containing /rc- 😄

Actually. I hadn't noticed it.
Opened a discussion in the develop PR.

vitorhugods
vitorhugods requested changes Jul 17, 2023
View reviewed changes
Copy link
Member

@vitorhugods vitorhugods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just speeding down as we discuss this /rc- prefix.

@Garzas Garzas requested a review from vitorhugods July 18, 2023 11:51
vitorhugods
vitorhugods approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@vitorhugods vitorhugods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨🏻‍🍳🤌🏻

@vitorhugods vitorhugods merged commit 293b099 into release/candidate Jul 18, 2023
@vitorhugods vitorhugods deleted the chore/cherry-pick-rc-to-dev branch July 18, 2023 12:16
@github-actions github-actions bot mentioned this pull request Jul 18, 2023
Closed
@github-actions
Copy link
Contributor

Build (beta-debug) available here. Scroll down to Artifacts!

@github-actions
Copy link
Contributor

Build (dev-debug) available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2 succeeded.

The build produced the following APK's:

@vitorhugods vitorhugods mentioned this pull request Jul 18, 2023
Merged
4 tasks
@github-actions github-actions bot mentioned this pull request Jul 18, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitorhugods vitorhugods vitorhugods approved these changes

@alexandreferris alexandreferris alexandreferris approved these changes

@typfel typfel Awaiting requested review from typfel

@yamilmedina yamilmedina Awaiting requested review from yamilmedina

@MohamadJaara MohamadJaara Awaiting requested review from MohamadJaara

Assignees

@Garzas Garzas

Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Garzas @AndroidBob @vitorhugods @alexandreferris