fix: conv admin for unconnected user [WPB-3043] #1955
Conversation
|
Build 1 failed. |
|
On this "after" screen the group info part looks like it's out of place, can you ask Wolfgang how it should look in such case when we are not connected but need to show the group member info for that user? EDIT: Thanks @Garzas for showing me designs |
|
Build (beta-debug) available here. Scroll down to Artifacts! |
|
Build (dev-debug) available here. Scroll down to Artifacts! |
| OtherUserProfileTabItem.DETAILS -> | ||
| OtherUserProfileDetails(state, otherUserProfileScreenState, lazyListStates[tabItem]!!) | ||
| Column { | ||
| OtherUserConnectionStatusInfo(state.connectionState, state.membership) |
There was a problem hiding this comment.
Now, with extracting OtherUserConnectionStatusInfo out of the Crossfade we no longer have a "fade" animation when user clicks "connect" and the connection state changes - if that's fine then it can be accepted, but I always cry inside a little when someone decreases the overall user experience level 😄
|
Build (dev-debug) available here. Scroll down to Artifacts! |
|
Build (beta-debug) available here. Scroll down to Artifacts! |
|
Build 5 succeeded. The build produced the following APK's: |
|
Build 7 failed. |
|
Build (dev-debug) available here. Scroll down to Artifacts! |
|
Build (beta-debug) available here. Scroll down to Artifacts! |
|
Build 8 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
When user is BLOCKED or NOT CONNECTED we don't show group admin options on other user profile
Causes (Optional)
We cannot remove user from conversation or change his role
Solutions
Don't depend on user connection status to show group tab
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)