-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: send text formatting logic #1969
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MessageCompositionHolder
could get some new tests ;)
This reverts commit cade4ac.
Codecov Report
@@ Coverage Diff @@
## develop #1969 +/- ##
=============================================
+ Coverage 38.24% 38.49% +0.24%
- Complexity 886 892 +6
=============================================
Files 287 287
Lines 11313 11313
Branches 1449 1449
=============================================
+ Hits 4327 4355 +28
+ Misses 6559 6530 -29
- Partials 427 428 +1
Continue to review full report in Codecov by Sentry.
|
Build (dev-debug) available here. Scroll down to Artifacts! |
Build (beta-debug) available here. Scroll down to Artifacts! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👨🏻🍳🤌🏻
Build (beta-debug) available here. Scroll down to Artifacts! |
Build (dev-debug) available here. Scroll down to Artifacts! |
Build 514 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
When sending text formatting for Header or Bold, it was a bit misplaced in the logic
# #
was going for header**
was going for boldCauses (Optional)
Logic was handling when
isBold
and notisHeader
Solutions
Change logic to handle from
isHeader
and not fromisBold