Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sending reply does not clear the quoted message #1970

Merged
merged 4 commits into from
Jul 19, 2023

Conversation

trOnk12
Copy link
Contributor

@trOnk12 trOnk12 commented Jul 19, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • When replying to the message after it is send, user gets stuck on reply mode.

Solutions

  • Clear the state after sending the reply

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@CLAassistant
Copy link

CLAassistant commented Jul 19, 2023

CLA assistant check
All committers have signed the CLA.

@trOnk12 trOnk12 changed the title fix:sending reply does not clear the quoted message fix: sending reply does not clear the quoted message Jul 19, 2023
Copy link
Member

@vitorhugods vitorhugods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test for it?

@trOnk12 trOnk12 requested a review from vitorhugods July 19, 2023 09:39
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #1970 (ae1c36b) into develop (8a9dbdf) will decrease coverage by 0.24%.
The diff coverage is 100.00%.

❗ Current head ae1c36b differs from pull request most recent head 7727df7. Consider uploading reports for the commit 7727df7 to get more accurate results

@@              Coverage Diff              @@
##             develop    #1970      +/-   ##
=============================================
- Coverage      38.49%   38.25%   -0.24%     
+ Complexity       892      886       -6     
=============================================
  Files            287      287              
  Lines          11313    11315       +2     
  Branches        1449     1449              
=============================================
- Hits            4355     4329      -26     
- Misses          6530     6559      +29     
+ Partials         428      427       -1     
Impacted Files Coverage Δ
.../messagecomposer/state/MessageCompositionHolder.kt 15.63% <100.00%> (-12.59%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a9dbdf...7727df7. Read the comment docs.

@github-actions
Copy link
Contributor

Build (beta-debug) available here. Scroll down to Artifacts!

@github-actions
Copy link
Contributor

Build (dev-debug) available here. Scroll down to Artifacts!

@github-actions
Copy link
Contributor

Test Results

500 tests  ±0   499 ✔️ ±0   20s ⏱️ -18s
  73 suites ±0       1 💤 ±0 
  73 files   ±0       0 ±0 

Results for commit ae1c36b. ± Comparison against base commit f594a29.

@AndroidBob
Copy link
Collaborator

Build 508 succeeded.

The build produced the following APK's:

@tmspzz tmspzz requested review from a team, typfel, gongracr, alexandreferris and ohassine and removed request for a team July 19, 2023 10:37
@trOnk12 trOnk12 merged commit b6f6b1f into develop Jul 19, 2023
@trOnk12 trOnk12 deleted the fix/reply_not_clearing branch July 19, 2023 12:27
@github-actions
Copy link
Contributor

Build (dev-debug) available here. Scroll down to Artifacts!

@github-actions
Copy link
Contributor

Build (beta-debug) available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 523 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants