Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing self deleting text label and enabled button state[WPB-3312] #1978

Merged
merged 7 commits into from
Jul 21, 2023

Conversation

trOnk12
Copy link
Contributor

@trOnk12 trOnk12 commented Jul 19, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • When the message was self-deleting, we missed the correct label and the button state.

Solutions

  • Use correct label and enable the button when the message is self-deleting.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@CLAassistant
Copy link

CLAassistant commented Jul 19, 2023

CLA assistant check
All committers have signed the CLA.

@trOnk12 trOnk12 changed the title Fix/self deleting message label fix: missing self deleting text label and enabled button state[WPB-3312] Jul 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2023

Test Results

506 tests  ±0   505 ✔️ ±0   21s ⏱️ -1s
  74 suites ±0       1 💤 ±0 
  74 files   ±0       0 ±0 

Results for commit b6cc9b4. ± Comparison against base commit 60427b4.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 549 failed.

@AndroidBob
Copy link
Collaborator

Build 573 failed.

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #1978 (084cee6) into develop (60427b4) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head 084cee6 differs from pull request most recent head b6cc9b4. Consider uploading reports for the commit b6cc9b4 to get more accurate results

@@              Coverage Diff              @@
##             develop    #1978      +/-   ##
=============================================
- Coverage      38.51%   38.49%   -0.02%     
  Complexity       892      892              
=============================================
  Files            287      287              
  Lines          11318    11321       +3     
  Branches        1450     1451       +1     
=============================================
- Hits            4359     4358       -1     
- Misses          6531     6535       +4     
  Partials         428      428              
Impacted Files Coverage Δ
...essagecomposer/state/MessageComposerStateHolder.kt 69.09% <ø> (ø)
.../messagecomposer/state/MessageCompositionHolder.kt 28.90% <ø> (ø)
...mposer/state/MessageCompositionInputStateHolder.kt 53.60% <0.00%> (-2.92%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60427b4...b6cc9b4. Read the comment docs.

@AndroidBob
Copy link
Collaborator

Build 577 failed.

@github-actions
Copy link
Contributor

Build (dev-debug) available here. Scroll down to Artifacts!

@github-actions
Copy link
Contributor

Build (beta-debug) available here. Scroll down to Artifacts!

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 587 succeeded.

The build produced the following APK's:

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@trOnk12 trOnk12 added this pull request to the merge queue Jul 21, 2023
@AndroidBob
Copy link
Collaborator

Build 599 succeeded.

The build produced the following APK's:

Merged via the queue into develop with commit f5267d5 Jul 21, 2023
@trOnk12 trOnk12 deleted the fix/self_deleting_message_label branch July 21, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants