Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide sender name from notification if message is ephemeral (WPB-2431) #1981

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

alexandreferris
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When receiving a ephemeral message notification, sender name would show either null or You (but you were not the sender, thus receiving a notification)

Solutions

Verify if message type is ephemeral, if so then hide setting sender name into the notification

How to Test

  • Open App
  • Receive an ephemeral notification from another user
  • Check that neither null or You is shown on the left side of the message, along with Someone sent a Message

Attachments (Optional)

Screenshot 2023-07-20 at 12 21 16 Screenshot 2023-07-20 at 12 21 10

@alexandreferris alexandreferris self-assigned this Jul 20, 2023
@alexandreferris alexandreferris requested review from a team, MohamadJaara, vitorhugods, mchenani, Garzas and trOnk12 and removed request for a team July 20, 2023 14:10
@github-actions
Copy link
Contributor

Build (beta-debug) available here. Scroll down to Artifacts!

@github-actions
Copy link
Contributor

Build (dev-debug) available here. Scroll down to Artifacts!

@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2023

Test Results

506 tests   505 ✔️  21s ⏱️
  74 suites      1 💤
  74 files        0

Results for commit 4af39ce.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 575 succeeded.

The build produced the following APK's:

@AndroidBob
Copy link
Collaborator

Build 575 failed.

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #1981 (4af39ce) into develop (65edf8e) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #1981      +/-   ##
=============================================
- Coverage      38.51%   38.50%   -0.01%     
  Complexity       892      892              
=============================================
  Files            287      287              
  Lines          11316    11317       +1     
  Branches        1449     1450       +1     
=============================================
  Hits            4358     4358              
- Misses          6530     6531       +1     
  Partials         428      428              
Impacted Files Coverage Δ
...android/notification/MessageNotificationManager.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cfbc7f...4af39ce. Read the comment docs.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 585 succeeded.

The build produced the following APK's:

@tmspzz tmspzz added this pull request to the merge queue Jul 21, 2023
Merged via the queue into develop with commit d45713b Jul 21, 2023
@tmspzz tmspzz deleted the fix/hide_null_sender_name_in_ephemeral_notification branch July 21, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants