-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hide sender name from notification if message is ephemeral (WPB-2431) #1981
fix: hide sender name from notification if message is ephemeral (WPB-2431) #1981
Conversation
Build (beta-debug) available here. Scroll down to Artifacts! |
Build (dev-debug) available here. Scroll down to Artifacts! |
Build 575 succeeded. The build produced the following APK's: |
Build 575 failed. |
Codecov Report
@@ Coverage Diff @@
## develop #1981 +/- ##
=============================================
- Coverage 38.51% 38.50% -0.01%
Complexity 892 892
=============================================
Files 287 287
Lines 11316 11317 +1
Branches 1449 1450 +1
=============================================
Hits 4358 4358
- Misses 6530 6531 +1
Partials 428 428
Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 585 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
When receiving a ephemeral message notification, sender name would show either
null
orYou
(but you were not the sender, thus receiving a notification)Solutions
Verify if message type is ephemeral, if so then hide setting sender name into the notification
How to Test
null
orYou
is shown on the left side of the message, along withSomeone sent a Message
Attachments (Optional)