Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade kotlin to 1.9.0 #1992

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Conversation

vitorhugods
Copy link
Member

@vitorhugods vitorhugods commented Jul 21, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Kotlin 1.9.0 is released. We're just a tiny bit behind.

We could benefit, from some stuff like data object.

Better to upgrade little-by-little than being forced to upgrade everything at once.

Solutions

Upgrade it!

Required:

  • compose-compiler from 1.4.7 to 1.5.0

So I've also bumped Kotlin in Kalium.

Dependencies

Needs releases with:

Testing

Tested manually, ran the app, everything great.

Test Coverage (Optional)

N/A


PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Required:
- compose-compiler from 1.4.7 to 1.5.0
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #1992 (6c462a9) into develop (f5267d5) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #1992   +/-   ##
==========================================
  Coverage      38.49%   38.50%           
  Complexity       892      892           
==========================================
  Files            287      287           
  Lines          11323    11321    -2     
  Branches        1452     1455    +3     
==========================================
  Hits            4359     4359           
+ Misses          6536     6534    -2     
  Partials         428      428           

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5267d5...6c462a9. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2023

Test Results

506 tests  ±0   505 ✔️ ±0   23s ⏱️ -6s
  74 suites ±0       1 💤 ±0 
  74 files   ±0       0 ±0 

Results for commit 6c462a9. ± Comparison against base commit f5267d5.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 604 succeeded.

The build produced the following APK's:

@vitorhugods vitorhugods enabled auto-merge July 21, 2023 12:40
@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 605 succeeded.

The build produced the following APK's:

@vitorhugods vitorhugods added this pull request to the merge queue Jul 24, 2023
Merged via the queue into develop with commit 24f9c77 Jul 24, 2023
@vitorhugods vitorhugods deleted the chore/upgrade-kotlin-to-1.9 branch July 24, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants