fix: app crash when download asset #2092
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
When downloading an asset from the context menu, we were not checking for saving to external permission when user was on Android 9 (API level 28) or lower.
Causes (Optional)
We were not checking permissions.
Solutions
Change
downloadAssetExternally
todownloadOrFetchAssetAndShowDialog
so there is a Dialog handling everything:And showing a snackbar when successfully saved.
Testing
How to Test
Download
from the context menuSave
then asking permission will be shown