feat: avatar border and message padding improvements [WPB-5059] #2428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garzas
requested review from
yamilmedina,
alexandreferris,
ohassine and
saleniuk
|
APKs built during tests are available here. Scroll down to Artifacts! |
saleniuk
approved these changes
Nov 15, 2023
| @@ -270,7 +270,7 @@ sealed class UIMessageContent { | |||
| sealed class SystemMessage( | |||
| @DrawableRes val iconResId: Int?, | |||
| @StringRes open val stringResId: Int, | |||
| val isSmallIcon: Boolean = true, | |||
| val isSmallIcon: Boolean = false, | |||
There was a problem hiding this comment.
suggestion: so right now all system messages have "large icon", right? If so then we can remove this parameter completely 😄
There was a problem hiding this comment.
There is one exception for this and I will add some code for it
alexandreferris
approved these changes
Nov 15, 2023
|
Build 1839 succeeded. The build produced the following APK's: |
4 tasks
|
APKs built during tests are available here. Scroll down to Artifacts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)