-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show pending legal hold request and approve it [WPB-4393] #2484
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2484 +/- ##
=============================================
+ Coverage 40.94% 41.47% +0.53%
- Complexity 1098 1104 +6
=============================================
Files 348 348
Lines 12713 12764 +51
Branches 1660 1664 +4
=============================================
+ Hits 5205 5294 +89
+ Misses 7018 6976 -42
- Partials 490 494 +4
Continue to review full report in Codecov by Sentry.
|
Test Results714 tests +19 714 ✔️ +19 7m 21s ⏱️ + 1m 41s Results for commit af03752. ± Comparison against base commit 2dd5d83. This pull request removes 1 and adds 20 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
APKs built during tests are available here. Scroll down to Artifacts! |
app/src/main/kotlin/com/wire/android/ui/common/topappbar/CommonTopAppBarViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/com/wire/android/ui/common/topappbar/CommonTopAppBarViewModel.kt
Show resolved
Hide resolved
app/src/main/kotlin/com/wire/android/ui/common/topappbar/CommonTopAppBarViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/com/wire/android/ui/common/topappbar/CommonTopAppBarViewModel.kt
Outdated
Show resolved
Hide resolved
APKs built during tests are available here. Scroll down to Artifacts! |
APKs built during tests are available here. Scroll down to Artifacts! |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
The logic in view models to show the bar informing about pending legal hold request and a dialog with the option to approve this request.
Testing
Test Coverage (Optional)
How to Test
As a team admin request the legal hold for the user, then this user should see this bar and dialog when he/she opens the app.
Attachments (Optional)
approve_legal_hold.mp4
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.