Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove playtest branch action and adjust size labels to kalium values #2547

Merged
merged 5 commits into from
Dec 21, 2023

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Dec 21, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

A bit of housekeeping.

  • Remove unused playtest branch creator action
  • Adjust labels of size of PR to what we have on kalium.
  • Updates kalium ref.

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Dec 21, 2023
@yamilmedina yamilmedina requested review from a team, typfel, alexandreferris, borichellow, MohamadJaara, Garzas and ohassine and removed request for a team December 21, 2023 09:53
Copy link
Contributor

github-actions bot commented Dec 21, 2023

Test Results

737 tests  ±0   737 ✔️ ±0   10m 52s ⏱️ + 3m 51s
101 suites ±0       0 💤 ±0 
101 files   ±0       0 ±0 

Results for commit 0bde6f9. ± Comparison against base commit 4f27d50.

♻️ This comment has been updated with latest results.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Copy link
Contributor

@alexandreferris alexandreferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@AndroidBob
Copy link
Collaborator

Build 2408 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina added this pull request to the merge queue Dec 21, 2023
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@yamilmedina yamilmedina changed the title chore: remove playtest action and adjust size labels to kalium values chore: remove playtest branch action and adjust size labels to kalium values Dec 21, 2023
@yamilmedina yamilmedina removed this pull request from the merge queue due to a manual request Dec 21, 2023
@MohamadJaara MohamadJaara added this pull request to the merge queue Dec 21, 2023
@AndroidBob
Copy link
Collaborator

Build 2412 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina removed this pull request from the merge queue due to a manual request Dec 21, 2023
@@ -348,6 +348,7 @@ fun EphemeralMessageExpiredLabel(isSelfMessage: Boolean, conversationDetailsData
@Composable
fun MessageExpireLabel(messageContent: UIMessageContent?, timeLeft: String) {
when (messageContent) {
is UIMessageContent.Location,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this as the kalium reference was updated.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@yamilmedina yamilmedina added this pull request to the merge queue Dec 21, 2023
@AndroidBob
Copy link
Collaborator

Build 2413 succeeded.

The build produced the following APK's:

Merged via the queue into develop with commit 556c866 Dec 21, 2023
12 checks passed
@yamilmedina yamilmedina deleted the chore/cleanup-actions branch December 21, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants