Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: message item long tap action [WPB-5952] #2553

Merged
merged 1 commit into from
Dec 22, 2023
Merged

fix: message item long tap action [WPB-5952] #2553

merged 1 commit into from
Dec 22, 2023

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Dec 22, 2023 •
edited by github-actions bot
Loading

BugWPB-5952 [Android] When longtapping on whitespace next to message, message menu does not open

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • fixed long tap on message

@Garzas Garzas self-assigned this Dec 22, 2023
@github-actions GitHub Actions
Copy link
Contributor

Test Results

737 tests  ±0   737 ✔️ ±0   7m 59s ⏱️ - 3m 21s
101 suites ±0       0 💤 ±0 
101 files   ±0       0 ❌ ±0 

Results for commit 7a915da. ± Comparison against base commit 8a9969a.

@github-actions GitHub Actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2428 succeeded.

The build produced the following APK's:

borichellow
borichellow approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@borichellow borichellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally it's fixed! Thanks :)

@Garzas Garzas added this pull request to the merge queue Dec 22, 2023
Merged via the queue into develop with commit 069d619 Dec 22, 2023
12 checks passed
@Garzas Garzas deleted the fix/message-item-longtap branch December 22, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borichellow borichellow borichellow approved these changes

@saleniuk saleniuk saleniuk approved these changes

Assignees

@Garzas Garzas

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Garzas @AndroidBob @borichellow @saleniuk