Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Indicate user with valid E2EI certificate (WPB-3228) #2561

Merged
merged 8 commits into from
Jan 11, 2024

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Dec 28, 2023

StoryWPB-3228 [Android] 5.3.16 Indicate user with valid certificates

What's new in this PR?

Show if user has valid E2EI Certificate in UserProfile and Conversations participants list

Dependencies (Optional)

kalium PR

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

Copy link
Contributor

github-actions bot commented Dec 28, 2023

Test Results

742 tests  ±0   742 ✅ ±0   11m 15s ⏱️ + 1m 59s
102 suites ±0     0 💤 ±0 
102 files   ±0     0 ❌ ±0 

Results for commit 2ea53b3. ± Comparison against base commit 1a59e12.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.
com.wire.android.ui.home.conversations.details.participants.usecase.ObserveParticipantsForConversationUseCaseTest ‑ given a group members, when solving the participants list with limit, then limited sizes are passed()
com.wire.android.ui.home.conversations.details.participants.usecase.ObserveParticipantsForConversationUseCaseTest ‑ given a group members, when solving the participants list without limit, then all lists are passed()
com.wire.android.ui.home.conversations.details.participants.usecase.ObserveParticipantsForConversationUseCaseTest ‑ givenGroupMembers_whenSolvingTheParticipantsListWithLimit_thenLimitedSizesArePassed()
com.wire.android.ui.home.conversations.details.participants.usecase.ObserveParticipantsForConversationUseCaseTest ‑ givenGroupMembers_whenSolvingTheParticipantsListWithoutLimit_thenAllListsArePassed()

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1a59e12) 41.23% compared to head (2ea53b3) 41.24%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2561      +/-   ##
=============================================
+ Coverage      41.23%   41.24%   +0.01%     
+ Complexity      1138     1132       -6     
=============================================
  Files            361      361              
  Lines          13202    13206       +4     
  Branches        1743     1744       +1     
=============================================
+ Hits            5444     5447       +3     
  Misses          7226     7226              
- Partials         532      533       +1     
Files Coverage Δ
...ations/details/participants/model/UIParticipant.kt 100.00% <100.00%> (ø)
...ecase/ObserveParticipantsForConversationUseCase.kt 93.33% <100.00%> (+0.47%) ⬆️
...roid/ui/userprofile/other/OtherUserProfileState.kt 75.55% <100.00%> (+0.55%) ⬆️
...lin/com/wire/android/mapper/UIParticipantMapper.kt 38.70% <50.00%> (-0.64%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a59e12...2ea53b3. Read the comment docs.

Copy link
Contributor

github-actions bot commented Jan 3, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2444 succeeded.

The build produced the following APK's:

@AndroidBob
Copy link
Collaborator

Build 2453 failed.

Copy link
Contributor

@mchenani mchenani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛡️

@AndroidBob
Copy link
Collaborator

Build 2509 failed.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2510 succeeded.

The build produced the following APK's:

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@borichellow borichellow added this pull request to the merge queue Jan 11, 2024
Merged via the queue into develop with commit 701dd64 Jan 11, 2024
14 of 15 checks passed
@borichellow borichellow deleted the feat/indicate_user_with_valid_e2ei_certificate branch January 11, 2024 11:03
@AndroidBob
Copy link
Collaborator

Build 2515 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants