Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2ei): loading e2ei state during the app initialisation #2664

Merged

Conversation

mchenani
Copy link
Contributor

@mchenani mchenani commented Feb 6, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Loading the e2ei state if it's blocking the client registration during login when reopening the app as a blocking value.

Issues

The value of e2ei state was not loaded in blocking state, causes incorrect behaviour.

How to Test

Login with an account that has E2EI enabled on their team, then while getting the E2EI certificate, kill and re open the app; the app must open the enrol certificate screen again to continue from there.

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Feb 6, 2024

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 4c6314b.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 2885 failed.

@AndroidBob
Copy link
Collaborator

Build 3354 failed.

@mchenani mchenani enabled auto-merge (squash) February 28, 2024 15:31
@AndroidBob
Copy link
Collaborator

Build 3370 failed.

@AndroidBob
Copy link
Collaborator

Build 3414 failed.

@mchenani mchenani merged commit a5ab875 into release/candidate Mar 1, 2024
10 of 11 checks passed
@mchenani mchenani deleted the release/fix/getting-e2ei-state-during-registration branch March 1, 2024 06:27
Copy link
Contributor

github-actions bot commented Mar 1, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3415 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants