-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(e2ei): loading e2ei state during the app initialisation #2664
Merged
mchenani
merged 13 commits into
release/candidate
from
release/fix/getting-e2ei-state-during-registration
Mar 1, 2024
Merged
fix(e2ei): loading e2ei state during the app initialisation #2664
mchenani
merged 13 commits into
release/candidate
from
release/fix/getting-e2ei-state-during-registration
Mar 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 4c6314b. ♻️ This comment has been updated with latest results. |
Build 2885 failed. |
saleniuk
approved these changes
Feb 7, 2024
…during-registration
Build 3354 failed. |
…ndroid-reloaded into release/fix/getting-e2ei-state-during-registration
MohamadJaara
approved these changes
Feb 28, 2024
Build 3370 failed. |
…during-registration
…during-registration
…ndroid-reloaded into release/fix/getting-e2ei-state-during-registration
…uring-registration' into release/fix/getting-e2ei-state-during-registration
Build 3414 failed. |
6 tasks
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3415 succeeded. The build produced the following APK's: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Loading the e2ei state if it's blocking the client registration during login when reopening the app as a blocking value.
Issues
The value of e2ei state was not loaded in blocking state, causes incorrect behaviour.
How to Test
Login with an account that has E2EI enabled on their team, then while getting the E2EI certificate, kill and re open the app; the app must open the enrol certificate screen again to continue from there.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.