chore: add client suffix on debug builds [ACOL-144] #2678
Conversation
| @@ -209,7 +210,8 @@ class CreateAccountCodeViewModel @Inject constructor( | |||
| clientScopeProviderFactory.create(userId).clientScope.getOrRegister( | |||
| RegisterClientUseCase.RegisterClientParam( | |||
| password = password, | |||
| capabilities = null | |||
| capabilities = null, | |||
| modelPostfix = if(BuildConfig.PRIVATE_BUILD) " [${BuildConfig.FLAVOR}_${BuildConfig.BUILD_TYPE}]" else null | |||
There was a problem hiding this comment.
Is PrivateBuild the correct parameter? Won't clients with custom builds also have that?
There was a problem hiding this comment.
Nevermind.
It seems we use PRIVATE_BUILD just for debug stuff. Only visible to us.
I guess we could name it better 🤔
Anyway. LGTM!
There was a problem hiding this comment.
Just checked and as default we go with false, if not set (like the case of those custom builds)
wire-android/buildSrc/src/main/kotlin/scripts/variants.gradle.kts
Lines 178 to 183 in 0f6bace
|
Build 3019 failed. |
vitorhugods
changed the title
vitorhugods
changed the title
|
Build 3030 failed. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2678 +/- ##
===========================================
+ Coverage 42.88% 42.97% +0.08%
===========================================
Files 405 405
Lines 13468 13473 +5
Branches 2377 2381 +4
===========================================
+ Hits 5776 5790 +14
+ Misses 7019 7001 -18
- Partials 673 682 +9
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 3031 succeeded. The build produced the following APK's: |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
When testing different app builds it's hard to know which device is prod build to not remove while adding new device
Solutions
In private builds add to device name flavor and build type
Dependencies
This PR depends on: