Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: text highlight colors [WPB-5940] #2680

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Feb 9, 2024

BugWPB-5940 [Android] When searching for a message in dark mode, search result is highlighted in very bright color


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Highlight text color and background are different than on the design documentation.

Solutions

  • change highlight background colors and remove invalid alpha value
  • add onHighlight color to scheme and use as highlight text color
  • update palette - change "Yellow" to "Amber" to be consistent with the design documentation

Testing

How to Test

Search for something, especially on dark mode.

Attachments (Optional)

Before After
Screenshot_20240209_164747 Screenshot_20240209_163833

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Feb 9, 2024

Test Results

794 tests   794 ✅  10m 9s ⏱️
108 suites    0 💤
108 files      0 ❌

Results for commit e54b44a.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 9, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3037 succeeded.

The build produced the following APK's:

@saleniuk saleniuk merged commit 6f61248 into release/candidate Feb 9, 2024
17 checks passed
@saleniuk saleniuk deleted the fix/highlight-colors branch February 9, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants