-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: filter markdown by query [5164] #2752
Conversation
Ups 🫰🟨This PR is too big. Please try to break it up into smaller PRs. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2752 +/- ##
===========================================
+ Coverage 43.03% 43.47% +0.43%
===========================================
Files 409 411 +2
Lines 13579 13845 +266
Branches 2399 2516 +117
===========================================
+ Hits 5844 6019 +175
- Misses 7055 7120 +65
- Partials 680 706 +26
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3397 succeeded. The build produced the following APK's: |
app/src/main/kotlin/com/wire/android/ui/markdown/MarkdownComposer.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/com/wire/android/ui/markdown/MarkdownComposer.kt
Outdated
Show resolved
Hide resolved
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3409 failed. |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3419 succeeded. The build produced the following APK's: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just small comments and suggestions. Superb work, I like the expressiveness of the Markdown model now.
app/src/main/kotlin/com/wire/android/ui/home/conversations/ConversationScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/com/wire/android/ui/markdown/MarkdownComposer.kt
Outdated
Show resolved
Hide resolved
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3435 succeeded. The build produced the following APK's: |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3494 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Causes (Optional)
Solutions
Attachments (Optional)