-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show accent-colored user names in conversations [WPB-6891] #2786
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2786 +/- ##
========================================
Coverage 43.43% 43.43%
========================================
Files 411 411
Lines 13863 13865 +2
Branches 2517 2518 +1
========================================
+ Hits 6021 6022 +1
Misses 7135 7135
- Partials 707 708 +1
Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3552 succeeded. The build produced the following APK's: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
IMHO, this is a total game changer for the app 🥰 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's so pretty ❤️
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
As a user, I want the profile color that I previously chose on web or iOS to reflect in my Android client.
I see the profile colors of other people reflected in their names in the conversation view
Note: this is not about enabling the user to change the profile color on Android. Just reading and displaying the color value.
Solutions
Provide enum class to map
accentId
and identify accents, createWireAccentColors
inWireColorScheme
to associate proper colors to accents and use it to color the user name on message headers. When no accent color set, default one (the same as until now) is applied.Testing
How to Test
Have a conversation with user who changed their accent color on web or iOS and receive some messages to see their user name color.
Attachments (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.