Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show accent-colored user names in conversations [WPB-6891] #2786

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Mar 12, 2024

StoryWPB-6891 [Android] Show profile color


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

As a user, I want the profile color that I previously chose on web or iOS to reflect in my Android client.
I see the profile colors of other people reflected in their names in the conversation view

Note: this is not about enabling the user to change the profile color on Android. Just reading and displaying the color value.

Solutions

Provide enum class to map accentId and identify accents, create WireAccentColors in WireColorScheme to associate proper colors to accents and use it to color the user name on message headers. When no accent color set, default one (the same as until now) is applied.

Testing

How to Test

Have a conversation with user who changed their accent color on web or iOS and receive some messages to see their user name color.

Attachments (Optional)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Mar 12, 2024

Test Results

857 tests  ±0   857 ✅ ±0   8m 56s ⏱️ +11s
116 suites ±0     0 💤 ±0 
116 files   ±0     0 ❌ ±0 

Results for commit e6baf13. ± Comparison against base commit eba05a8.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 43.43%. Comparing base (eba05a8) to head (e6baf13).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2786   +/-   ##
========================================
  Coverage    43.43%   43.43%           
========================================
  Files          411      411           
  Lines        13863    13865    +2     
  Branches      2517     2518    +1     
========================================
+ Hits          6021     6022    +1     
  Misses        7135     7135           
- Partials       707      708    +1     
Files Coverage Δ
...c/main/kotlin/com/wire/android/model/ImageAsset.kt 100.00% <ø> (ø)
.../wire/android/ui/home/conversations/MessageItem.kt 0.00% <ø> (ø)
...ui/home/conversations/model/MessageTypesPreview.kt 0.00% <ø> (ø)
...e/android/ui/home/conversations/model/UIMessage.kt 49.70% <100.00%> (+0.14%) ⬆️
...in/kotlin/com/wire/android/mapper/MessageMapper.kt 62.24% <0.00%> (-0.65%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eba05a8...e6baf13. Read the comment docs.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3552 succeeded.

The build produced the following APK's:

@saleniuk saleniuk requested review from a team, alexandreferris, MohamadJaara, mchenani, Garzas and e-lisa and removed request for a team March 13, 2024 08:51
Copy link
Contributor

@alexandreferris alexandreferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@yamilmedina
Copy link
Contributor

IMHO, this is a total game changer for the app 🥰
So beautiful and clear now the messages view 👏

@saleniuk saleniuk added this pull request to the merge queue Mar 13, 2024
Merged via the queue into develop with commit 3c901b2 Mar 13, 2024
14 checks passed
@saleniuk saleniuk deleted the feat/accent-colored-user-names branch March 13, 2024 13:50
Copy link
Member

@vitorhugods vitorhugods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's so pretty ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants