Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade APG to 8.3.2 #3079

Merged
merged 6 commits into from
Jun 6, 2024
Merged

chore: upgrade APG to 8.3.2 #3079

merged 6 commits into from
Jun 6, 2024

Conversation

vitorhugods
Copy link
Member

Issues

AGP 8.3.2 and Gradle 8.8 are available.

AGP 8.3.x fixes some Lint issues that we're facing on Android, so upgrading in Kalium is also necessary.

Solutions

  1. Bump it
  2. Bump kalium to match (fixing the breaking changes in Kalium's develop)
  3. Run baseline again to make sure we don't get new errors and clear the old fixed ones.

Testing

Tested on current IntelliJ and Android Studio versions. It all works fine.

CI should do the rest


PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@vitorhugods vitorhugods requested review from a team, typfel, mchenani, Garzas, ohassine and saleniuk and removed request for a team June 5, 2024 12:52
Copy link

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

# Conflicts:
#	app/lint-baseline.xml
@pull-request-size pull-request-size bot added size/L and removed size/XL labels Jun 5, 2024
@AndroidBob
Copy link
Collaborator

Build 5191 failed.

@AndroidBob
Copy link
Collaborator

Build 5202 failed.

Copy link

sonarqubecloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vitorhugods vitorhugods added this pull request to the merge queue Jun 6, 2024
@AndroidBob
Copy link
Collaborator

Build 5210 failed.

Merged via the queue into develop with commit 1f8b72e Jun 6, 2024
11 of 12 checks passed
@vitorhugods vitorhugods deleted the chore/upgrade-agp branch June 6, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants