Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add DataDog tokens to GitHub workflows [WPB-9788] #3116

Merged
merged 1 commit into from
Jun 24, 2024
Merged

ci: add DataDog tokens to GitHub workflows [WPB-9788] #3116

merged 1 commit into from
Jun 24, 2024

Conversation

vitorhugods
Copy link
Member

@vitorhugods vitorhugods commented Jun 21, 2024 •
edited by github-actions bot
Loading

TaskWPB-9788 [Android] Add event processing performance logs

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We have no Datadog in our private builds to gather metrics.

Solutions

Add the missing Datadog keys to all GH Workflows (except Prod builds).

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@vitorhugods vitorhugods requested review from MohamadJaara, a team, yamilmedina, borichellow, mchenani and Garzas and removed request for a team June 21, 2024 15:35
@vitorhugods vitorhugods enabled auto-merge June 21, 2024 15:35
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@vitorhugods vitorhugods changed the title ci: add DataDog tokens to GitHub workflows ci: add DataDog tokens to GitHub workflows [WPB-9788] Jun 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-release-pr-3116.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3116.apk is available for download

@vitorhugods vitorhugods added this pull request to the merge queue Jun 24, 2024
Merged via the queue into develop with commit 86dbace Jun 24, 2024
13 of 15 checks passed
@vitorhugods vitorhugods deleted the chore/add-datadog-secrets-to-build-file branch June 24, 2024 08:23
@echoes-hq echoes-hq bot added the echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamilmedina yamilmedina yamilmedina approved these changes

@MohamadJaara MohamadJaara MohamadJaara approved these changes

@borichellow borichellow Awaiting requested review from borichellow borichellow was automatically assigned from wireapp/android

@mchenani mchenani Awaiting requested review from mchenani mchenani was automatically assigned from wireapp/android

@Garzas Garzas Awaiting requested review from Garzas Garzas was automatically assigned from wireapp/android

Assignees

@vitorhugods vitorhugods

Labels
echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vitorhugods @yamilmedina @MohamadJaara