fix: handling ActivityNotFoundExceptions [WPB-9794] #3163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ups 🫰🟨This PR is too big. Please try to break it up into smaller PRs. |
…andle-activitynotfoundexceptions
…andle-activitynotfoundexceptions
…andle-activitynotfoundexceptions
MohamadJaara
approved these changes
Jul 5, 2024
saleniuk
requested review from
a team,
typfel,
borichellow,
vitorhugods,
Garzas and
ohassine
and removed request for
a team
|
Built wire-android-staging-compat-pr-3163.apk is available for download |
|
Built wire-android-dev-debug-pr-3163.apk is available for download |
…andle-activitynotfoundexceptions # Conflicts: # app/src/main/kotlin/com/wire/android/ui/home/messagecomposer/AdditionalOptions.kt # app/src/main/kotlin/com/wire/android/ui/home/messagecomposer/AttachmentOptions.kt # app/src/main/kotlin/com/wire/android/ui/home/settings/backup/dialog/restore/RestoreBackupDialogs.kt
|
|
Built wire-android-staging-compat-pr-3163.apk is available for download |
|
Built wire-android-dev-debug-pr-3163.apk is available for download |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
There are
ActivityNotFoundExceptions when executing actions that need to be handled by another apps, like taking a photo, capturing a video, choosing or saving file.Solutions
Handle these issues in a unified way by showing a snackbar with proper info (like "No camera app found to complete this action.").
It looks bigger than it actually is because multiple things were moved around as I took the possibility and simplified the code responsible for permissions and intents on this occasion, because all requests look basically the same, the difference is only type of permission or
ActivityResultContractso it can be unified without any duplicated code. Also, there were already multiple classes inside that package so they got grouped into basically two categories and combined in dedicated files: "permission requests" (only to get given permissions) and "intent permission requests" (to make action and ask for permission if needed).Testing
How to Test
Make any action that requires permission or is executed outside the app (take a picture, record a video, make a backup, choose image from gallery or asset from file manager).
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.