Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make smoke tests not report if github actions are aborted (WPB-9676) #3177

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

mythsunwind
Copy link
Collaborator

@mythsunwind mythsunwind commented Jul 9, 2024

TaskWPB-9676 Enable running end to end automation on Android PR


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

This PR changes the behaviour of the smoke test script to fail silently if github actions are aborted automatically (usually through a new commit or merge).

Copy link

sonarqubecloud bot commented Jul 9, 2024

@mythsunwind mythsunwind added this pull request to the merge queue Jul 9, 2024
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Built wire-android-staging-compat-pr-3177.apk is available for download

Copy link
Contributor

github-actions bot commented Jul 9, 2024

Built wire-android-dev-debug-pr-3177.apk is available for download

Merged via the queue into develop with commit 6306bee Jul 9, 2024
10 of 11 checks passed
@mythsunwind mythsunwind deleted the fix/smoketests-abort branch July 9, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants