Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Anonymous Analytics User Profile - (WPB-8978) #3226

Merged
merged 24 commits into from
Jul 30, 2024
Merged

feat: Add Anonymous Analytics User Profile - (WPB-8978) #3226

merged 24 commits into from
Jul 30, 2024

Conversation

alexandreferris
Copy link
Contributor

@alexandreferris alexandreferris commented Jul 23, 2024 •
edited by github-actions bot
Loading

TaskWPB-8978 [Android] Countly analytics ID and user properties

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We had no way of setting a user profile to current logged in user

Causes (Optional)

Not implemented.

Solutions

Implement a way to observe current logged in account, changes on analytics settings and possible analytics identifier coming from other clients.

Dependencies (Optional)

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

  • Open App
  • Login
  • From App Inspection check you analytics identifier from Metadata table and verify against on our analytics tool.
  • Same to be done when switching accounts
    • Login into same account on another platform (if android on same branch, better), already logged in user will receive a new tracking id from new logged in device and start using it

@alexandreferris
feat: add user profile property team_is_team
8fd2f09 
Signed-off-by: alexandreferris <[email protected]>
@alexandreferris
feat: add usage of kalium-data module in analytics modules
e8daaaf 
Signed-off-by: alexandreferris <[email protected]>
@alexandreferris
feat: add recorder set tracking identifier with and without merge and…
457ac51 
… user profile properties

Signed-off-by: alexandreferris <[email protected]>
@alexandreferris
feat: add recorder implementation
e0a2161 
Signed-off-by: alexandreferris <[email protected]>
@alexandreferris
feat: add handlers for migration and propagation of new identifier an…
6bb8613 
…d data class for combining analytics result

Signed-off-by: alexandreferris <[email protected]>
@alexandreferris
feat: update AnonymousAnalyticsManager to receive new flow of Analyti…
69ccb46 
…csResult and both new handlers

Signed-off-by: alexandreferris <[email protected]>
@alexandreferris
chore: remove unused import and add suppress to max parameters
f75b782 
Signed-off-by: alexandreferris <[email protected]>
@alexandreferris
feat: create use case to observe current session analytics to be used…
2d7836e 
… in wire application

Signed-off-by: alexandreferris <[email protected]>
@alexandreferris
feat: add a proper coroutine scope and mutex to handle changes in sam…
fbab6d0 
…e function

Signed-off-by: alexandreferris <[email protected]>
@alexandreferris
feat: add usage of new use case in wire application to observe curren…
9d59810 
…t account and analytics settings changes

Signed-off-by: alexandreferris <[email protected]>
@alexandreferris
test: add tests for ObserveCurrentSessionAnalyticsUseCaseTest and Ano…
aeec178 
…nymousAnalyticsManagerTest

Signed-off-by: alexandreferris <[email protected]>
@alexandreferris
chore: update kalium reference
4d7acb3 
Signed-off-by: alexandreferris <[email protected]>
@alexandreferris
Merge branch 'refs/heads/develop' into feat/analytics_tracking_identi…
ef3814e 
…fier_generation

# Conflicts:
#	kalium
@alexandreferris alexandreferris requested review from a team, typfel, yamilmedina, Garzas, ohassine, saleniuk and MohamadJaara and removed request for a team July 23, 2024 14:42
@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3226.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3226.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3226.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3226.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3226.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3226.apk is available for download

@alexandreferris alexandreferris added WIP Work In Progress DO NOT MERGE labels Jul 24, 2024
@alexandreferris alexandreferris mentioned this pull request Jul 24, 2024
Merged
6 tasks
@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3226.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3226.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3226.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3226.apk is available for download

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3226.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3226.apk is available for download

@MohamadJaara MohamadJaara added this pull request to the merge queue Jul 30, 2024
Merged via the queue into develop with commit a601eab Jul 30, 2024
12 checks passed
@MohamadJaara MohamadJaara deleted the feat/analytics_tracking_identifier_generation branch July 30, 2024 08:26
@alexandreferris alexandreferris removed WIP Work In Progress DO NOT MERGE labels Jul 31, 2024
@alexandreferris alexandreferris mentioned this pull request Jul 31, 2024
Merged
5 tasks
alexandreferris added a commit that referenced this pull request Aug 1, 2024
@alexandreferris
feat: Add Anonymous Analytics User Profile - (WPB-8978) (#3226)
303884d 
Signed-off-by: alexandreferris <[email protected]>
(cherry picked from commit a601eab)
@alexandreferris alexandreferris mentioned this pull request Aug 1, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitorhugods vitorhugods vitorhugods approved these changes

@yamilmedina yamilmedina yamilmedina approved these changes

@typfel typfel Awaiting requested review from typfel typfel was automatically assigned from wireapp/android

@Garzas Garzas Awaiting requested review from Garzas Garzas was automatically assigned from wireapp/android

@ohassine ohassine Awaiting requested review from ohassine ohassine was automatically assigned from wireapp/android

@saleniuk saleniuk Awaiting requested review from saleniuk saleniuk was automatically assigned from wireapp/android

@MohamadJaara MohamadJaara Awaiting requested review from MohamadJaara

Assignees

@alexandreferris alexandreferris

Labels
echoes/initiative: product-metrics-in-countly Analytics and KPIs size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexandreferris @yamilmedina @vitorhugods @MohamadJaara