chore: use manifest placeholder to get rid of playstore error (WPB-8645) 🍒 #3230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
cherry-pick
saleniuk
approved these changes
Jul 25, 2024
yamilmedina
requested review from
yamilmedina,
a team,
typfel,
MohamadJaara,
Garzas and
ohassine
and removed request for
a team
alexandreferris
approved these changes
Jul 25, 2024
|
|
Built wire-android-staging-compat-pr-3230.apk is available for download |
|
Built wire-android-dev-debug-pr-3230.apk is available for download |
yamilmedina
deleted the
chore/dont-use-buildconfig-forgcpapikey-cherry-pick
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
We have an "error/warning" from the play store console, suggesting to not use keys directly
Generated
BuildConfigare plain text and accessible by the scanner of the playstore console.Causes (Optional)
We are seeing that we can not release Beta/Blue apps in the playstore to internal testers
Solutions
Follow "best practices" and use manifest placeholder instead for this API key.
How to test / testing
The app should build, and if you build locally, you should see the substitution in the merged
AndroidManifestfrom the build directory.PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.