Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update strings copies by content writer (WPB-9776) #3249

Merged
merged 3 commits into from
Jul 30, 2024
Merged

chore: update strings copies by content writer (WPB-9776) #3249

merged 3 commits into from
Jul 30, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Jul 30, 2024 •
edited by github-actions bot
Loading

TaskWPB-9776 [GitHub Action] Update translation

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Adjust strings translations according to content writer specs.

Causes (Optional)

Adjustments and typos

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina requested a review from a team July 30, 2024 09:55
@yamilmedina yamilmedina self-assigned this Jul 30, 2024
@yamilmedina yamilmedina requested review from alexandreferris, borichellow, vitorhugods, ohassine and saleniuk and removed request for a team July 30, 2024 09:55
@yamilmedina yamilmedina requested a review from MohamadJaara July 30, 2024 09:55
@yamilmedina yamilmedina changed the title chore: update strings content (WPB-9776) chore: update strings copies by content writer (WPB-9776) Jul 30, 2024
@yamilmedina yamilmedina enabled auto-merge July 30, 2024 10:02
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@yamilmedina yamilmedina added this pull request to the merge queue Jul 30, 2024
Merged via the queue into release/candidate with commit eaf3d76 Jul 30, 2024
11 of 12 checks passed
@yamilmedina yamilmedina deleted the chore/updatestrings branch July 30, 2024 10:47
github-actions bot pushed a commit that referenced this pull request Jul 30, 2024
@yamilmedina @github-actions
chore: update strings copies by content writer (WPB-9776) (#3249)
c95dedd
@github-actions github-actions bot mentioned this pull request Jul 30, 2024
Merged
6 tasks
@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3249.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-internal-compat-pr-3249.apk is available for download

@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garzas Garzas Garzas approved these changes

@alexandreferris alexandreferris alexandreferris approved these changes

@borichellow borichellow Awaiting requested review from borichellow borichellow was automatically assigned from wireapp/android

@vitorhugods vitorhugods Awaiting requested review from vitorhugods vitorhugods was automatically assigned from wireapp/android

@ohassine ohassine Awaiting requested review from ohassine ohassine was automatically assigned from wireapp/android

@saleniuk saleniuk Awaiting requested review from saleniuk saleniuk was automatically assigned from wireapp/android

@MohamadJaara MohamadJaara Awaiting requested review from MohamadJaara

Assignees

@yamilmedina yamilmedina

Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yamilmedina @alexandreferris @Garzas