fix: add loading screen when importing asset (WPB-10217) #3260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alexandreferris <[email protected]>
Signed-off-by: alexandreferris <[email protected]>
echoes-hq
bot
added
echoes: unplanned
Ups 🫰🟨This PR is too big. Please try to break it up into smaller PRs. |
alexandreferris
removed
echoes: technical-roadmap/technical-debt
alexandreferris
requested review from
a team,
typfel,
MohamadJaara,
mchenani,
Garzas and
saleniuk
and removed request for
a team
Signed-off-by: alexandreferris <[email protected]>
|
Built wire-android-staging-compat-pr-3260.apk is available for download |
|
Built wire-android-internal-compat-pr-3260.apk is available for download |
MohamadJaara
approved these changes
Jul 31, 2024
…when_sharing_asset
|
Built wire-android-staging-compat-pr-3260.apk is available for download |
|
Built wire-android-internal-compat-pr-3260.apk is available for download |
|
|
Built wire-android-staging-compat-pr-3260.apk is available for download |
|
Built wire-android-internal-compat-pr-3260.apk is available for download |
saleniuk
approved these changes
Aug 1, 2024
alexandreferris
deleted the
fix/add_default_loading_screen_when_sharing_asset
branch
github-actions bot
pushed a commit
that referenced
this pull request
Aug 1, 2024
Signed-off-by: alexandreferris <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
When sharing an asset from the Gallery/Files and the app was previously closed, it would show a screen for the user to login for a split second even though the user was logged in.
Causes (Optional)
There was no state for loading while we fetch current logged in user.
Solutions
Add a new state for
LoadinginFeatureFlagState.FileSharingStateso it can display the default loading screen for the split second.Testing
How to Test
Attachments (Optional)