Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix workflow runs against target branches rc and develop (WPB-8645) #3263

Merged
merged 8 commits into from
Aug 1, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Aug 1, 2024

EpicWPB-8645 [Android] Infrastructure code and developer experience


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Smoke tests only run against develop

Causes (Optional)

Failing smoke tests on RC

Solutions

Wait for the correct workflow run to get the apk


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Aug 1, 2024

Built wire-android-staging-compat-pr-3263.apk is available for download

Copy link
Contributor

github-actions bot commented Aug 1, 2024

Built wire-android-internal-compat-pr-3263.apk is available for download

@yamilmedina yamilmedina requested review from alexandreferris, MohamadJaara, CinnamonNinja, a team, typfel, ohassine and saleniuk and removed request for a team August 1, 2024 12:52
@yamilmedina yamilmedina enabled auto-merge August 1, 2024 12:54
Copy link

sonarqubecloud bot commented Aug 1, 2024

Copy link
Contributor

github-actions bot commented Aug 1, 2024

Built wire-android-staging-compat-pr-3263.apk is available for download

Copy link
Contributor

github-actions bot commented Aug 1, 2024

Built wire-android-internal-compat-pr-3263.apk is available for download

@yamilmedina yamilmedina added this pull request to the merge queue Aug 1, 2024
Merged via the queue into release/candidate with commit 45614c1 Aug 1, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants