Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure request focus is called once after the first composition is done [WPB-10571] #3323

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Aug 14, 2024

BugWPB-10571 [Android] crash in create account screen because of focus requester


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

IllegalStateException in create account screen

Causes (Optional)

request focus is called before the first compisition is done

Solutions

thanks to @saleniuk who pointed out this issue tracker ticket with the suggested fix to move the LaunchEffect inside the Scaffold

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Aug 14, 2024
@MohamadJaara MohamadJaara enabled auto-merge August 14, 2024 06:25
Copy link

@MohamadJaara MohamadJaara changed the title fix: ensure request focus is called once after the first composition is done fix: ensure request focus is called once after the first composition is done [WPB-10571] Aug 14, 2024
Copy link
Contributor

Built wire-android-staging-compat-pr-3323.apk is available for download

Copy link
Contributor

Built wire-android-internal-compat-pr-3323.apk is available for download

@MohamadJaara MohamadJaara added this pull request to the merge queue Aug 14, 2024
Merged via the queue into release/candidate with commit eb15ac3 Aug 14, 2024
13 of 15 checks passed
@MohamadJaara MohamadJaara deleted the fix/WPB-10571 branch August 14, 2024 07:53
github-actions bot pushed a commit that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants