Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: builds for QA nightly builds missing folder (WPB-10408) #3329

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Aug 15, 2024

TaskWPB-10408 [Android] Enable QA again to access release builds for nightly runs


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Fixing a missing path for RC builds of type release, used by QA nightly runs.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina changed the title fix: builds for QA nightly builds (WPB-10408) fix: builds for QA nightly builds missing folder (WPB-10408) Aug 15, 2024
@yamilmedina yamilmedina requested review from a team, MohamadJaara, vitorhugods, Garzas, ohassine, saleniuk, alexandreferris and CinnamonNinja and removed request for a team August 15, 2024 12:07
Copy link
Contributor

Built wire-android-staging-compat-pr-3329.apk is available for download

Copy link
Contributor

Built wire-android-internal-compat-pr-3329.apk is available for download

@yamilmedina yamilmedina enabled auto-merge August 15, 2024 12:48
@yamilmedina yamilmedina disabled auto-merge August 15, 2024 15:58
Copy link
Contributor

Built wire-android-staging-compat-pr-3329.apk is available for download

Copy link
Contributor

Built wire-android-internal-compat-pr-3329.apk is available for download

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.74%. Comparing base (a404cdf) to head (8f47d57).

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/candidate    #3329   +/-   ##
==================================================
  Coverage              44.74%   44.74%           
==================================================
  Files                    456      456           
  Lines                  15396    15396           
  Branches                2573     2573           
==================================================
  Hits                    6889     6889           
  Misses                  7780     7780           
  Partials                 727      727           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a404cdf...8f47d57. Read the comment docs.

Copy link

Copy link
Contributor

Built wire-android-staging-compat-pr-3329.apk is available for download

Copy link
Contributor

Built wire-android-internal-compat-pr-3329.apk is available for download

@yamilmedina yamilmedina added this pull request to the merge queue Aug 19, 2024
Merged via the queue into release/candidate with commit 585f6cb Aug 19, 2024
12 of 13 checks passed
@yamilmedina yamilmedina deleted the fix/builds-for-qa-nightly branch August 19, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants