Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show analytics initialized for automation (WPB-10600) 🍒 #3332

Conversation

alexandreferris
Copy link
Contributor

@alexandreferris alexandreferris commented Aug 16, 2024

TaskWPB-10600 [Android] Show countly details in debug settings


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

There was no way for automation (or our Playtest users) to verify if Analytics was enabled or disabled + tracking identifier through the app. (without having to run locally and check manually)

Causes (Optional)

Not implemented

Solutions

  • Add item in Debug Screen if Analytics is enabled or disabled
  • Add item in Debug Screen to show tracking identifier if it is enabled
  • Added STAGING env. along with PROD env. for verifications of analytics.
  • Show privacy settings toggle based on verifications (PROD/STAGING env)

Dependencies (Optional)

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

  • Open App (Beta or Staging) with PROD or STAGING env.
  • Login
  • Agree or Decline with Analytics
  • Open Debug Settings Screen
  • Check for Analytics status and tracking ID (if enabled)

Attachments (Optional)

Signed-off-by: alexandreferris <[email protected]>

(cherry picked from commit a404cdf)
Signed-off-by: alexandreferris <[email protected]>
Signed-off-by: alexandreferris <[email protected]>
@alexandreferris alexandreferris self-assigned this Aug 16, 2024
Copy link

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 42.85714% with 16 lines in your changes missing coverage. Please review.

Project coverage is 44.61%. Comparing base (683d79a) to head (0519219).
Report is 1 commits behind head on develop.

Files Patch % Lines
...wire/android/ui/debug/DebugDataOptionsViewModel.kt 0.00% 9 Missing ⚠️
.../home/settings/privacy/PrivacySettingsViewModel.kt 61.53% 0 Missing and 5 partials ⚠️
...re/android/ui/analytics/AnalyticsUsageViewModel.kt 66.66% 0 Missing and 1 partial ⚠️
...com/wire/android/ui/debug/DebugDataOptionsState.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3332      +/-   ##
===========================================
- Coverage    44.62%   44.61%   -0.01%     
===========================================
  Files          456      456              
  Lines        15382    15404      +22     
  Branches      2564     2572       +8     
===========================================
+ Hits          6864     6873       +9     
- Misses        7798     7806       +8     
- Partials       720      725       +5     
Files Coverage Δ
...d/ui/home/settings/privacy/PrivacySettingsState.kt 100.00% <100.00%> (ø)
...re/android/ui/analytics/AnalyticsUsageViewModel.kt 93.10% <66.66%> (+0.51%) ⬆️
...com/wire/android/ui/debug/DebugDataOptionsState.kt 0.00% <0.00%> (ø)
.../home/settings/privacy/PrivacySettingsViewModel.kt 50.72% <61.53%> (+0.72%) ⬆️
...wire/android/ui/debug/DebugDataOptionsViewModel.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 683d79a...0519219. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3332.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3332.apk is available for download

@alexandreferris alexandreferris requested review from a team, yamilmedina, borichellow, MohamadJaara, vitorhugods and ohassine and removed request for a team August 16, 2024 08:16
@alexandreferris alexandreferris added this pull request to the merge queue Aug 16, 2024
Merged via the queue into develop with commit 717e1e9 Aug 16, 2024
13 of 14 checks passed
@alexandreferris alexandreferris deleted the feat/show_analytics_initialized_for_automation_cherry_pick branch August 16, 2024 15:31
@echoes-hq echoes-hq bot added echoes/initiative: product-metrics-in-countly Analytics and KPIs echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... labels Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/initiative: product-metrics-in-countly Analytics and KPIs echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants