feat: attachments popup [WPB-10499] #3373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garzas
requested review from
yamilmedina,
alexandreferris,
MohamadJaara,
ohassine and
saleniuk
echoes-hq
bot
added
the
echoes: unplanned
Ups 🫰🟨This PR is too big. Please try to break it up into smaller PRs. |
gradle/libs.versions.toml
Outdated
| @@ -63,6 +63,7 @@ hilt-work = "1.2.0" | |||
| # Android UI | |||
| accompanist = "0.32.0" # adjusted to work with compose-destinations "1.9.54" | |||
| material = "1.12.0" | |||
| material3 = "1.3.0-beta05" | |||
There was a problem hiding this comment.
there is already 1.3.0-rc01 available maybe we can give it a try
yamilmedina
approved these changes
Aug 26, 2024
|
|
Built wire-android-staging-compat-pr-3373.apk is available for download |
|
Built wire-android-dev-debug-pr-3373.apk is available for download |
alexandreferris
approved these changes
Aug 27, 2024
| fun requestFocus() { | ||
| if (!inputFocused) { | ||
| focusRequester.requestFocus() | ||
| focusRequester.captureFocus() // TODO check |
There was a problem hiding this comment.
I will check and remove it after playtest
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
This pull request addresses various issues related to inconsistent state management of attachments and the keyboard across different Android devices and versions. The main focus was on enhancing the user experience by streamlining processes and rectifying bugs that affected the UI's behavior during interactions with the bottom sheets and attachments.
Causes (Optional)
The underlying causes of the issues included buggy state management mechanisms that varied across different devices and Android versions. There were inconsistencies in how attachments and keyboard heights were handled, leading to a user experience that could often feel unpredictable and jumpy, particularly when transitioning between different states of the UI.
Solutions
Centralized Bottom Sheet Management: Consolidated all bottom sheets (location, self-deleting, edit) into a single management point to ensure consistency across different parts of the application.
IME Padding Workaround: Implemented a workaround for hardcoded IME padding within the bottom sheet. This helps to prevent the bottom sheet from jumping when the keyboard is dismissed, ensuring a smoother transition and a more stable user interface.
Enhanced Animations: Introduced animations for showing and hiding attachments, which not only improve the aesthetics but also provide clearer feedback to the user regarding the UI's state changes.
Attachments Popup with Ripple Reveal Animation: Added a ripple reveal animation for the attachments popup, which enhances visual engagement and makes the interface more interactive and responsive to user actions.
Simplified Process Management: Streamlined the processes for managing the visibility of attachments and the height adjustments of the keyboard and attachments. This simplification helps reduce complexity and improves the maintainability of the code.
Removed Redundant Workarounds and States: Eliminated the read-only mode workaround that was previously required for managing text input, and also removed unnecessary states for attachments that complicated the state management unnecessarily.
How to Test
Play around with message composer and all attachments
Attachments (Optional)
Screen_recording_20240826_134114.webm