-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display error dialog when handling deeplinks #WPB-282 #3486
feat: display error dialog when handling deeplinks #WPB-282 #3486
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3486 +/- ##
===========================================
+ Coverage 44.43% 44.46% +0.02%
===========================================
Files 466 466
Lines 15744 15745 +1
Branches 2653 2653
===========================================
+ Hits 6996 7001 +5
+ Misses 7991 7990 -1
+ Partials 757 754 -3
Continue to review full report in Codecov by Sentry.
|
Quality Gate passedIssues Measures |
Built wire-android-staging-compat-pr-3486.apk is available for download |
Built wire-android-dev-debug-pr-3486.apk is available for download |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
https://wearezeta.atlassian.net/browse/WPB-282
What's new in this PR?
Issues
When we were opening a deeplink with malformed server url nothing happened in the app.
Right now user will see a dialogue that the JSON is malformed.
The only thing is that on the design we've had different scenario for no internet/malformed json but with the current API implementation that is not possible, because in both cases we're getting the same error message, so we can not distinguish lack of internet connection to malformed url
Solutions
We have not been handling the error right now, so now there is an additional state for the dialogue to be used.
Testing
How to Test
Attachments (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.