Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display error dialog when handling deeplinks #WPB-282 #3486

Merged

Conversation

m-zagorski
Copy link
Contributor

@m-zagorski m-zagorski commented Oct 8, 2024

TaskWPB-282 User gets no information if deeplink json file is not reachable or broken

https://wearezeta.atlassian.net/browse/WPB-282

What's new in this PR?

Issues

When we were opening a deeplink with malformed server url nothing happened in the app.
Right now user will see a dialogue that the JSON is malformed.

The only thing is that on the design we've had different scenario for no internet/malformed json but with the current API implementation that is not possible, because in both cases we're getting the same error message, so we can not distinguish lack of internet connection to malformed url

Solutions

We have not been handling the error right now, so now there is an additional state for the dialogue to be used.

Testing

How to Test

Attachments (Optional)

Screenshot_20241008_114246_Wire Beta


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@m-zagorski m-zagorski requested a review from saleniuk October 8, 2024 09:47
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Oct 8, 2024
@m-zagorski m-zagorski requested a review from Garzas October 8, 2024 09:47
@CLAassistant
Copy link

CLAassistant commented Oct 8, 2024

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 44.46%. Comparing base (59f9c3d) to head (e0f3109).
Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
...otlin/com/wire/android/ui/WireActivityViewModel.kt 62.50% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3486      +/-   ##
===========================================
+ Coverage    44.43%   44.46%   +0.02%     
===========================================
  Files          466      466              
  Lines        15744    15745       +1     
  Branches      2653     2653              
===========================================
+ Hits          6996     7001       +5     
+ Misses        7991     7990       -1     
+ Partials       757      754       -3     
Files with missing lines Coverage Δ
...droid/ui/authentication/login/sso/LoginSSOState.kt 100.00% <100.00%> (ø)
...d/ui/authentication/login/sso/LoginSSOViewModel.kt 73.64% <100.00%> (ø)
...otlin/com/wire/android/ui/WireActivityViewModel.kt 71.33% <62.50%> (+1.43%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59f9c3d...e0f3109. Read the comment docs.

@m-zagorski m-zagorski changed the title Display error dialog when handling deeplinks #WPB-282 feat: display error dialog when handling deeplinks #WPB-282 Oct 8, 2024
Copy link

sonarqubecloud bot commented Oct 8, 2024

Copy link
Contributor

github-actions bot commented Oct 8, 2024

Built wire-android-staging-compat-pr-3486.apk is available for download

Copy link
Contributor

github-actions bot commented Oct 8, 2024

Built wire-android-dev-debug-pr-3486.apk is available for download

Copy link
Contributor

@saleniuk saleniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@yamilmedina yamilmedina added this pull request to the merge queue Oct 11, 2024
Merged via the queue into develop with commit 4256b55 Oct 11, 2024
12 checks passed
@yamilmedina yamilmedina deleted the feat/display-error-dialog-when-handling-deeplinks branch October 11, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants