Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix for frdroid build and gh action for deps (WPB-8645) #3514

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Oct 15, 2024

EpicWPB-8645 [Android] Infrastructure code and developer experience


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Fdroid builds are not running, because of a parsing error in the command

Solutions

Fix it and also added to dependabot the jira placeholder for dependencies update


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Oct 15, 2024
@yamilmedina yamilmedina requested review from m-zagorski, Garzas, ohassine, a team, alexandreferris and borichellow and removed request for a team October 15, 2024 23:19
@yamilmedina yamilmedina enabled auto-merge October 15, 2024 23:20
Copy link

Copy link
Contributor

Built wire-android-staging-compat-pr-3514.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3514.apk is available for download

@yamilmedina yamilmedina added this pull request to the merge queue Oct 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 16, 2024
@yamilmedina yamilmedina added this pull request to the merge queue Oct 16, 2024
Merged via the queue into develop with commit 47c2b69 Oct 16, 2024
14 checks passed
@yamilmedina yamilmedina deleted the ci/general-fixes branch October 16, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants