Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create team upgrade flow (WPB-11268) #3517

Merged
merged 15 commits into from
Oct 23, 2024
Merged

feat: Create team upgrade flow (WPB-11268) #3517

merged 15 commits into from
Oct 23, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Oct 16, 2024 •
edited
Loading

StoryWPB-11268 [Android] Start and follow team creation flow for personal users

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

A follow up PR of #3497

This PR creates the flow that allow the user to migrate from personal to team account.

I created a new navGraph PersonalToTeamMigrationNavGraph so we can display all steps in it.
And for all the screens are using a sharedViewModel called TeamMigrationViewModel

This is just the UI part, no API calls involved here.

(That "open team flow" is just used to start the flow)

screen-20241016-134509.mp4

Needs releases with:

  • GitHub link to other pull request

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@pull-request-size Pull Request Size
Copy link

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

@ohassine ohassine requested review from a team, vitorhugods, mchenani, Garzas, damian-kaczmarek and mathias-niboulies and removed request for a team October 16, 2024 12:03
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 45.24%. Comparing base (44292c7) to head (3aa410f).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...serprofile/teammigration/TeamMigrationViewModel.kt 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3517      +/-   ##
===========================================
- Coverage    45.25%   45.24%   -0.01%     
===========================================
  Files          469      470       +1     
  Lines        15721    15724       +3     
  Branches      2630     2630              
===========================================
  Hits          7114     7114              
- Misses        7860     7863       +3     
  Partials       747      747
Files with missing lines Coverage Δ
...serprofile/teammigration/TeamMigrationViewModel.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44292c7...3aa410f. Read the comment docs.

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3517.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3517.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3517.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3517.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3517.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3517.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3517.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3517.apk is available for download

damian-kaczmarek
damian-kaczmarek suggested changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@damian-kaczmarek damian-kaczmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all of comments are request to change, some are just me trying to understand code better

.../main/kotlin/com/wire/android/ui/authentication/create/details/CreateAccountDetailsScreen.kt Outdated Show resolved Hide resolved
app/src/main/kotlin/com/wire/android/ui/userprofile/teammigration/BulletList.kt Outdated Show resolved Hide resolved
app/src/main/kotlin/com/wire/android/ui/userprofile/teammigration/TeamMigrationScreen.kt Show resolved Hide resolved
...otlin/com/wire/android/ui/userprofile/teammigration/step1/TeamMigrationTeamPlanStepScreen.kt Outdated Show resolved Hide resolved
...otlin/com/wire/android/ui/userprofile/teammigration/step1/TeamMigrationTeamPlanStepScreen.kt Outdated Show resolved Hide resolved
...n/com/wire/android/ui/userprofile/teammigration/step3/TeamMigrationConfirmationStepScreen.kt Show resolved Hide resolved
...in/kotlin/com/wire/android/ui/userprofile/teammigration/step4/TeamMigrationDoneStepScreen.kt Outdated Show resolved Hide resolved
...otlin/com/wire/android/ui/userprofile/teammigration/step2/TeamMigrationTeamNameStepScreen.kt Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3517.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3517.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3517.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3517.apk is available for download

damian-kaczmarek
damian-kaczmarek approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@damian-kaczmarek damian-kaczmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments but not really significant ✅

app/src/main/kotlin/com/wire/android/ui/userprofile/teammigration/TeamMigrationScreen.kt Show resolved Hide resolved
...n/com/wire/android/ui/userprofile/teammigration/step3/TeamMigrationConfirmationStepScreen.kt Show resolved Hide resolved
...otlin/com/wire/android/ui/userprofile/teammigration/step2/TeamMigrationTeamNameStepScreen.kt Show resolved Hide resolved
MohamadJaara
MohamadJaara approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@MohamadJaara MohamadJaara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work as always

@ohassine ohassine enabled auto-merge October 23, 2024 10:26
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ohassine ohassine mentioned this pull request Oct 23, 2024
Merged
8 tasks
@ohassine ohassine added this pull request to the merge queue Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-compat-pr-3517.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3517.apk is available for download

Merged via the queue into develop with commit acf4562 Oct 23, 2024
11 of 12 checks passed
@ohassine ohassine deleted the team_upgrade_flow branch October 23, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damian-kaczmarek damian-kaczmarek damian-kaczmarek approved these changes

@MohamadJaara MohamadJaara MohamadJaara approved these changes

@vitorhugods vitorhugods Awaiting requested review from vitorhugods vitorhugods was automatically assigned from wireapp/android

@mchenani mchenani Awaiting requested review from mchenani mchenani was automatically assigned from wireapp/android

@Garzas Garzas Awaiting requested review from Garzas Garzas was automatically assigned from wireapp/android

@mathias-niboulies mathias-niboulies Awaiting requested review from mathias-niboulies mathias-niboulies was automatically assigned from wireapp/android

Assignees

@ohassine ohassine

Labels
echoes/initiative: personal-users-to-team-users... size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ohassine @codecov-commenter @MohamadJaara @damian-kaczmarek