Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable QR code by feature flag (WPB-11921) #3569

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Oct 30, 2024

TaskWPB-11921 [Android] Implement a feature flag for QR code feature


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

It was defined that some changes needs to be discussed before release, so it's better to disable it for now, until new decisions are made.

Solutions

  • Use a feature flag to disable the QR code screen
  • Don't consider deeplink handling, since this is internal to the app, and will allow to open user profiles links (plain) that other clients might share (this was never ported from scala to reloaded)

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Open your user profile, there should not be a QR code button to open the screen.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Oct 30, 2024
@yamilmedina yamilmedina requested review from a team, m-zagorski, borichellow, Garzas, saleniuk and mathias-niboulies and removed request for a team October 30, 2024 09:09
Copy link

Copy link
Contributor

Built wire-android-staging-compat-pr-3569.apk is available for download

@MohamadJaara
Copy link
Member

MohamadJaara commented Oct 30, 2024

can you also disable the processing of the deep link
@yamilmedina

@yamilmedina yamilmedina added this pull request to the merge queue Oct 30, 2024
Merged via the queue into release/candidate with commit 4fceaf1 Oct 30, 2024
13 of 14 checks passed
@yamilmedina yamilmedina deleted the feat/feature-flag-qrcode branch October 30, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants