Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: apply QR profile feature flag to deeplink processing (WPB-11921) #3581

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Nov 4, 2024

TaskWPB-11921 [Android] Implement a feature flag for QR code feature


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

There are some pending definitions for QR processing.

Solutions

Put the deeplink processor under the feature flag so we wait for output of the RFC


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Nov 4, 2024
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Nov 4, 2024
@yamilmedina yamilmedina requested review from MohamadJaara, Garzas, a team, m-zagorski, borichellow and vitorhugods and removed request for a team November 4, 2024 14:27
Copy link

sonarqubecloud bot commented Nov 4, 2024

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.35%. Comparing base (6593a50) to head (944d04c).

Files with missing lines Patch % Lines
...om/wire/android/util/deeplink/DeepLinkProcessor.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/candidate    #3581   +/-   ##
==================================================
  Coverage              45.35%   45.35%           
==================================================
  Files                    470      470           
  Lines                  15717    15716    -1     
  Branches                2627     2626    -1     
==================================================
  Hits                    7128     7128           
+ Misses                  7839     7838    -1     
  Partials                 750      750           
Files with missing lines Coverage Δ
...om/wire/android/util/deeplink/DeepLinkProcessor.kt 74.61% <0.00%> (+0.56%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6593a50...944d04c. Read the comment docs.

Copy link
Contributor

github-actions bot commented Nov 4, 2024

Built wire-android-staging-compat-pr-3581.apk is available for download

@yamilmedina yamilmedina added this pull request to the merge queue Nov 5, 2024
Merged via the queue into release/candidate with commit ccb1b8b Nov 5, 2024
15 of 16 checks passed
@yamilmedina yamilmedina deleted the chore/featureflag-qr branch November 5, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants