Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove mls enabled build config field #WPB-10119 #3591

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

m-zagorski
Copy link
Contributor

@m-zagorski m-zagorski commented Nov 6, 2024

StoryWPB-10119 [Android] Clients should initialize MLS clients according to backend feature flag

What's new in this PR?

Issues

Removing mls build config field as we're no longer rely on it.

Solutions

We moved away from this check, now backend is deciding about mls being enabled or not


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

sonarqubecloud bot commented Nov 6, 2024

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Built wire-android-staging-compat-pr-3591.apk is available for download

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Built wire-android-dev-debug-pr-3591.apk is available for download

@m-zagorski m-zagorski merged commit 8501ad1 into develop Nov 6, 2024
12 of 13 checks passed
@m-zagorski m-zagorski deleted the feat/remove-mls-enabled-build-config branch November 6, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/initiative: federation-and-mls-on-wire-c... Activate Federation with MLS on Wire Cloud size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants