Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow admins to remove groups [WPB-11559] #3652

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

m-zagorski
Copy link
Contributor

@m-zagorski m-zagorski commented Nov 21, 2024

StoryWPB-11559 [Android] Delete a group as admin

https://wearezeta.atlassian.net/browse/WPB-11559

What's new in this PR?

Issues

Allow not only creators of the groups to delete them but also admins who are in the same team.

Solutions

Check if user has an admin role and is in the same team - if so allow him to delete the group

Testing

How to Test

  • Create a group in the same team -> make member an admin -> he is able to delete the group
  • Create a group with user from different team -> make him an admin -> he is not able to delete the group

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Project coverage is 46.00%. Comparing base (7cd4bd6) to head (0b6d858).

Files with missing lines Patch % Lines
...tlin/com/wire/android/mapper/ConversationMapper.kt 0.00% 0 Missing and 1 partial ⚠️
...tions/details/GroupConversationDetailsViewModel.kt 66.66% 0 Missing and 1 partial ⚠️
...tions/usecase/GetConversationsFromSearchUseCase.kt 83.33% 0 Missing and 1 partial ⚠️
...ome/conversationslist/ConversationListViewModel.kt 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3652   +/-   ##
========================================
  Coverage    46.00%   46.00%           
========================================
  Files          472      472           
  Lines        16093    16102    +9     
  Branches      2664     2668    +4     
========================================
+ Hits          7403     7408    +5     
- Misses        7917     7918    +1     
- Partials       773      776    +3     
Files with missing lines Coverage Δ
...i/home/conversationslist/model/ConversationItem.kt 76.71% <100.00%> (ø)
...tlin/com/wire/android/mapper/ConversationMapper.kt 66.31% <0.00%> (-1.06%) ⬇️
...tions/details/GroupConversationDetailsViewModel.kt 66.48% <66.66%> (-0.19%) ⬇️
...tions/usecase/GetConversationsFromSearchUseCase.kt 85.41% <83.33%> (-0.63%) ⬇️
...ome/conversationslist/ConversationListViewModel.kt 32.23% <50.00%> (+0.14%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cd4bd6...0b6d858. Read the comment docs.

---- 🚨 Try these New Features:

Copy link
Contributor

Built wire-android-staging-compat-pr-3652.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3652.apk is available for download

@m-zagorski m-zagorski added this pull request to the merge queue Nov 26, 2024
Merged via the queue into develop with commit 90c9cba Nov 26, 2024
12 of 13 checks passed
@m-zagorski m-zagorski deleted the feat/allow-admins-to-remove-groups branch November 26, 2024 22:55
@echoes-hq echoes-hq bot added the echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants