-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add on profile account details btn WPB-970 #3654
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3654 +/- ##
========================================
Coverage 45.76% 45.76%
========================================
Files 472 472
Lines 16027 16027
Branches 2709 2708 -1
========================================
Hits 7335 7335
Misses 7929 7929
Partials 763 763
Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3654.apk is available for download |
Built wire-android-dev-debug-pr-3654.apk is available for download |
core/ui-common/src/main/kotlin/com/wire/android/ui/theme/WireColorScheme.kt
Outdated
Show resolved
Hide resolved
Built wire-android-staging-compat-pr-3654.apk is available for download |
Built wire-android-dev-debug-pr-3654.apk is available for download |
…profile-account-btn # Conflicts: # core/ui-common/src/main/kotlin/com/wire/android/ui/theme/WireColorScheme.kt
Built wire-android-staging-compat-pr-3654.apk is available for download |
Built wire-android-dev-debug-pr-3654.apk is available for download |
…profile-account-btn # Conflicts: # app/src/main/kotlin/com/wire/android/mapper/OtherAccountMapper.kt # app/src/test/kotlin/com/wire/android/mapper/OtherAccountMapperTest.kt
|
Built wire-android-staging-compat-pr-3654.apk is available for download |
Built wire-android-dev-debug-pr-3654.apk is available for download |
PR Submission Checklist for internal contributors
What's new in this PR?
Solutions
dividerPersonalToTeamMigration
todividerNew
as it uses the same divider colours, the currentdivider
colour is used in strange places so I left is as is. Using thedivider
colour would cause for a Divider to not be visible in dark modeAttachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.