Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add on profile account details btn WPB-970 #3654

Merged
merged 5 commits into from
Nov 29, 2024

Conversation

damian-kaczmarek
Copy link
Contributor

@damian-kaczmarek damian-kaczmarek commented Nov 21, 2024

StoryWPB-970 Navigating from user profile to account settings


PR Submission Checklist for internal contributors

What's new in this PR?

Solutions

  • add account details button on self profile
  • changed buttons style according to the designs, removed shadow and button box elevation
  • changed from team name to @ userHandle@domain in accounts list
  • renamed colour dividerPersonalToTeamMigration to dividerNew as it uses the same divider colours, the current divider colour is used in strange places so I left is as is. Using the divider colour would cause for a Divider to not be visible in dark mode
  • changed new team string

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

Before After
image image

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@damian-kaczmarek damian-kaczmarek self-assigned this Nov 21, 2024
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Nov 21, 2024
@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.76%. Comparing base (aa35a0b) to head (dbb6422).
Report is 64 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3654   +/-   ##
========================================
  Coverage    45.76%   45.76%           
========================================
  Files          472      472           
  Lines        16027    16027           
  Branches      2709     2708    -1     
========================================
  Hits          7335     7335           
  Misses        7929     7929           
  Partials       763      763           
Files with missing lines Coverage Δ
...tlin/com/wire/android/mapper/OtherAccountMapper.kt 83.33% <100.00%> (ø)
...id/ui/userprofile/self/SelfUserProfileViewModel.kt 56.93% <100.00%> (ø)
.../android/ui/userprofile/self/model/OtherAccount.kt 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa35a0b...dbb6422. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3654.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3654.apk is available for download

@damian-kaczmarek damian-kaczmarek marked this pull request as ready for review November 22, 2024 09:18
Copy link
Contributor

Built wire-android-staging-compat-pr-3654.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3654.apk is available for download

@damian-kaczmarek damian-kaczmarek requested review from a team, typfel, alexandreferris and vitorhugods and removed request for a team November 27, 2024 13:54
…profile-account-btn

# Conflicts:
#	core/ui-common/src/main/kotlin/com/wire/android/ui/theme/WireColorScheme.kt
Copy link
Contributor

Built wire-android-staging-compat-pr-3654.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3654.apk is available for download

…profile-account-btn

# Conflicts:
#	app/src/main/kotlin/com/wire/android/mapper/OtherAccountMapper.kt
#	app/src/test/kotlin/com/wire/android/mapper/OtherAccountMapperTest.kt
@damian-kaczmarek damian-kaczmarek added this pull request to the merge queue Nov 29, 2024
Copy link
Contributor

Built wire-android-staging-compat-pr-3654.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3654.apk is available for download

Merged via the queue into develop with commit 7983260 Nov 29, 2024
11 of 12 checks passed
@damian-kaczmarek damian-kaczmarek deleted the feat/profile-account-btn branch November 29, 2024 15:09
@echoes-hq echoes-hq bot added echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. and removed echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants