Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Crash on typing after sending mention (WPB-14897) #3719

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Dec 9, 2024

BugWPB-14897 [Android] Crash on typing after sending mention

What's new in this PR?

Issues

STR:

  • open group conv
  • send message with mention
  • start typing a new message
    Result: crash

Causes (Optional)

After sending a message selectedMentions field in MessageComposition state is not cleared and when user start typing a new message app tries to apply old mention to the new message

Solutions

clear selectedMentions after message send

@borichellow borichellow self-assigned this Dec 9, 2024
@yamilmedina yamilmedina changed the title fix: Crash on typing after sending mention fix: Crash on typing after sending mention (WPB-14897) Dec 9, 2024
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Dec 9, 2024
@yamilmedina yamilmedina enabled auto-merge December 9, 2024 11:19
Copy link

sonarqubecloud bot commented Dec 9, 2024

@yamilmedina yamilmedina added this pull request to the merge queue Dec 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.70%. Comparing base (31e4f00) to head (7bf384b).
Report is 42 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3719   +/-   ##
========================================
  Coverage    45.69%   45.70%           
========================================
  Files          473      473           
  Lines        16051    16052    +1     
  Branches      2713     2713           
========================================
+ Hits          7335     7336    +1     
  Misses        7955     7955           
  Partials       761      761           
Files with missing lines Coverage Δ
.../messagecomposer/state/MessageCompositionHolder.kt 28.82% <100.00%> (+0.42%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31e4f00...7bf384b. Read the comment docs.

Merged via the queue into develop with commit 062f329 Dec 9, 2024
12 of 13 checks passed
@yamilmedina yamilmedina deleted the fix/crash_on_typeing_after_sendind_mention branch December 9, 2024 11:54
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Built wire-android-staging-compat-pr-3719.apk is available for download

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Built wire-android-dev-debug-pr-3719.apk is available for download

@mastaab mastaab added echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. and removed echoes: unplanned Any work item that isn’t part of the product or technical roadmap. labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants