fix: attachments menu blends with background [WPB-15102] 🍒 #3765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
cherry-pick
|
saleniuk
requested review from
a team,
m-zagorski,
yamilmedina,
MohamadJaara,
vitorhugods and
sergeibakhtiarov
and removed request for
a team
yamilmedina
approved these changes
Dec 20, 2024
|
Built wire-android-staging-compat-pr-3765.apk is available for download |
|
Built wire-android-dev-debug-pr-3765.apk is available for download |
MohamadJaara
approved these changes
Dec 23, 2024
MohamadJaara
deleted the
fix/attachments_menu_blends_with_bg-cherry-pick
branch
mastaab
added
echoes: product-roadmap/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Attachments menu matches the background color of the conversation screen, making it difficult to distinguish the overlay from the background.
Solutions
Rearrange some surface colors, add border to the attachments menu in the way so that it is drawn properly even during animations.
Testing
How to Test
Open attachments menu on light and dark mode.
Attachments (Optional)
animation_10x_slower.mp4