You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WPB-15804 [Android] App crashing on oncoming group call if 2 users are logged in and in the same group conversation
What's new in this PR?
Issues
Crash receiving a call to non-currentUser
STR:
login on 2 users at 1 device
call into user that is not "current"
result: crash CallStyle notifications must either be for a foreground Service or use a fullScreenIntent.
wrong call ended on click Decline in notification
STR:
login on 2 users at 1 device
add both users to the same group
call in that group from some other user
receive 2 notifications about calling
decline call for current user
result: cal declined for non-currentUser
Causes (Optional)
For distinguish and do not auto-switching account when the call comes to non-currentUser we made notification for that users regular, not FullScreenIntent. But the problem that we can't use CallStyle for the notification in that case.
requestCode for the PendingIntent for actions in notification are the same for the same conversation but different users: while creating request code only conversationId is taken into consideration. As result: 2 notifications for 2 users but for the same conversation (in group call, or message in group) have actions with the same PendingIntents.
Solutions
Remove CallStyle for not-FullScreenIntent notifications and add regular Actions for open a call Or decline it.
Update creating requestCode for the PendingIntent to take userId into consideration.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
echoes-hq
bot
added
the
echoes: product-roadmap/bug
What's new in this PR?
Issues
STR:
result: crash
CallStyle notifications must either be for a foreground Service or use a fullScreenIntent.Declinein notificationSTR:
result: cal declined for non-currentUser
Causes (Optional)
FullScreenIntent. But the problem that we can't use CallStyle for the notification in that case.requestCodefor thePendingIntentfor actions in notification are the same for the same conversation but different users: while creating request code only conversationId is taken into consideration. As result: 2 notifications for 2 users but for the same conversation (in group call, or message in group) have actions with the same PendingIntents.Solutions
CallStylefor not-FullScreenIntent notifications and add regular Actions for open a call Or decline it.requestCodefor thePendingIntentto take userId into consideration.