-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: samsung keyboard not respecting enter to send [WPB-15994] #3870
fix: samsung keyboard not respecting enter to send [WPB-15994] #3870
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3870 +/- ##
========================================
Coverage 45.45% 45.45%
========================================
Files 491 491
Lines 17012 17012
Branches 2846 2846
========================================
Hits 7733 7733
Misses 8492 8492
Partials 787 787
Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3870.apk is available for download |
Built wire-android-dev-debug-pr-3870.apk is available for download |
|
Built wire-android-staging-compat-pr-3870.apk is available for download |
Built wire-android-dev-debug-pr-3870.apk is available for download |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
to send is disabled clicking enter on a Samsung or Microsoft keyboards will send the message regardless
Causes (Optional)
those keyboards are executing the code inside
onPreviewKeyEvent
even though in its docs it mentions that it is only for hardware keyboardsSolutions
replacing
onPreviewKeyEvent
withonKeyEvent
seems to work fineNeeds releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.