Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: samsung keyboard not respecting enter to send [WPB-15994] #3870

Merged

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Feb 10, 2025

TaskWPB-15994 [Android]"Press Enter to send" setting not working as expected


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

to send is disabled clicking enter on a Samsung or Microsoft keyboards will send the message regardless

Causes (Optional)

those keyboards are executing the code inside onPreviewKeyEvent even though in its docs it mentions that it is only for hardware keyboards

Solutions

replacing onPreviewKeyEvent with onKeyEvent seems to work fine

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.45%. Comparing base (8a13c77) to head (d1e990d).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3870   +/-   ##
========================================
  Coverage    45.45%   45.45%           
========================================
  Files          491      491           
  Lines        17012    17012           
  Branches      2846     2846           
========================================
  Hits          7733     7733           
  Misses        8492     8492           
  Partials       787      787           
Files with missing lines Coverage Δ
.../ui/home/messagecomposer/EnabledMessageComposer.kt 0.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a13c77...d1e990d. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3870.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3870.apk is available for download

Copy link
Contributor

Built wire-android-staging-compat-pr-3870.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3870.apk is available for download

@MohamadJaara MohamadJaara added this pull request to the merge queue Feb 11, 2025
Merged via the queue into develop with commit 61ccdfa Feb 11, 2025
12 of 13 checks passed
@MohamadJaara MohamadJaara deleted the fix/samsung-keyboard-not-respecting-enter-to-send branch February 11, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants