Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire Linux Process Name #125

Closed
sonicou opened this issue Oct 31, 2016 · 15 comments
Closed

Wire Linux Process Name #125

sonicou opened this issue Oct 31, 2016 · 15 comments

Comments

@sonicou
Copy link

sonicou commented Oct 31, 2016

The binary executeable and the processname under Linux use a capital W.
It should be "wire" not "Wire".

@ConorIA
Copy link
Contributor

ConorIA commented Oct 31, 2016

This is not a perfect solution, but if you are using the Debian packages, you can symlink to the /usr/bin directory:

# ln -s /opt/Wire/Wire /usr/bin/wire

@lipis
Copy link
Contributor

lipis commented Oct 31, 2016

If the general convention says lowercase we should update our build scripts accordingly..

@ConorIA
Copy link
Contributor

ConorIA commented Nov 3, 2016

Looks like electron-packager defaults to using productName. You can change the executable name using electron-builder by passing the flag --em.productName=wire. The only issue is that the "Wire" menu on Linux is also changed to "wire", so we'd have to change that menu title as well.

I see that there is a "name" option that can be passed to electron-packager, but couldn't figure out if it would work with electron-builder. See: https://github.com/electron-userland/electron-packager/blob/master/docs/api.md#name

@ConorIA
Copy link
Contributor

ConorIA commented Nov 3, 2016

I wonder if @develar can provide any insight into this issue. That is, is it possible to change the name of the executable on Linux without changing productName?

@develar
Copy link

develar commented Nov 3, 2016

electron-userland/electron-builder#806 will be fixed for you today.

@lipis
Copy link
Contributor

lipis commented Nov 3, 2016

🎆 Much appreciated @develar :)

@develar
Copy link

develar commented Nov 4, 2016

Update to electron-builder 7.21.0 to fix issue. name is used by default.

@develar
Copy link

develar commented Nov 4, 2016

BTW, why you still depends on electron-packager?

@lipis
Copy link
Contributor

lipis commented Nov 4, 2016

So what do I have to change now in order to have process name fixed?

@develar As for the electron-packager we were using that for Windows, macOS, MAS and it works smoothly at the moment with the Squirrel and everything.. I tried to do something quick.. but things start breaking fast :D So maybe in the future.. we might need your help there :) Gruntfile.coffee

@develar
Copy link

develar commented Nov 4, 2016

So what do I have to change now in order to have process name fixed?

Nothing. Just set electron-builder version to 7.21.0

@lipis
Copy link
Contributor

lipis commented Nov 4, 2016

Sweet! #151

@lipis
Copy link
Contributor

lipis commented Nov 4, 2016

Here it is... these versions will soon make it to production..

@lipis lipis closed this as completed Nov 4, 2016
@ConorIA
Copy link
Contributor

ConorIA commented Nov 4, 2016

@lipis, just a head's-up: users are going to have to re-login, because the config directory changes from Wire to wire. This could leave data behind when a user logs out because the old folder will still exist.

@lipis
Copy link
Contributor

lipis commented Nov 4, 2016

Thanks for the headsup.. It will be a bit tricky to start adding those things now in the experimental version of Wire for Linux.. so unfortunately that will happen now :/

@ConorIA
Copy link
Contributor

ConorIA commented Nov 4, 2016

Ooops, nevermind! The config directory is still $HOME/.config/Wire.
Ignore me. I was seeing something unrelated and jumped to conclusions. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants